Bugzilla – Attachment 84645 Details for
Bug 21610
Koha::Object->store needs to handle incorrect values
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21610: (QA follow-up) Better use columns_info from DBIx
Bug-21610-QA-follow-up-Better-use-columnsinfo-from.patch (text/plain), 1.08 KB, created by
Tomás Cohen Arazi (tcohen)
on 2019-02-01 19:22:34 UTC
(
hide
)
Description:
Bug 21610: (QA follow-up) Better use columns_info from DBIx
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2019-02-01 19:22:34 UTC
Size:
1.08 KB
patch
obsolete
>From 5e85d9839bd0bd31e7c912d7aca466a3132e8945 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 19 Oct 2018 11:05:50 +0200 >Subject: [PATCH] Bug 21610: (QA follow-up) Better use columns_info from DBIx > >We should better use the published method than a private hash key. >And shorter to go via _result than adding a new schema call. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Object.pm | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/Koha/Object.pm b/Koha/Object.pm >index 65790eb411..d388eadbdf 100644 >--- a/Koha/Object.pm >+++ b/Koha/Object.pm >@@ -121,8 +121,7 @@ Returns: > sub store { > my ($self) = @_; > >- my $columns_info = Koha::Database->new->schema->resultset( $self->_type ) >- ->result_source->{_columns}; >+ my $columns_info = $self->_result->result_source->columns_info; > > # Handle not null and default values for integers and dates > foreach my $col ( keys %{$columns_info} ) { >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21610
:
80880
|
80881
|
80882
|
80906
|
80926
|
80927
|
81016
|
81017
|
81018
|
81019
|
81020
|
81021
|
84601
|
84602
|
84603
|
84604
|
84605
|
84606
|
84642
|
84643
|
84644
| 84645 |
84646
|
84647