Bugzilla – Attachment 84752 Details for
Bug 21944
Fix waiting holds at wrong location bug
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21944: Test for Circulation.pm
Bug-21944-Test-for-Circulationpm.patch (text/plain), 2.00 KB, created by
Nick Clemens (kidclamp)
on 2019-02-04 20:48:40 UTC
(
hide
)
Description:
Bug 21944: Test for Circulation.pm
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2019-02-04 20:48:40 UTC
Size:
2.00 KB
patch
obsolete
>From 3d49d968c19e736af5b4f1804533db042fe8679b Mon Sep 17 00:00:00 2001 >From: Christopher Brannon <cbrannon@cdalibrary.org> >Date: Thu, 13 Dec 2018 00:08:54 +0000 >Subject: [PATCH] Bug 21944: Test for Circulation.pm > >--- > t/db_dependent/Circulation.t | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 707582d44a..ea187715f3 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -43,6 +43,7 @@ use Koha::Patrons; > use Koha::Subscriptions; > use Koha::Account::Lines; > use Koha::Account::Offsets; >+use Koha::Items; > > my $schema = Koha::Database->schema; > $schema->storage->txn_begin; >@@ -2379,7 +2380,7 @@ subtest '_FixOverduesOnReturn' => sub { > }; > > subtest 'Set waiting flag' => sub { >- plan tests => 4; >+ plan tests => 9; > > my $library_1 = $builder->build( { source => 'Branch' } ); > my $patron_1 = $builder->build( { source => 'Borrower', value => { branchcode => $library_1->{branchcode}, categorycode => $patron_category->{categorycode} } } ); >@@ -2427,6 +2428,17 @@ subtest 'Set waiting flag' => sub { > is( $hold->found, 'W', 'Hold is waiting' ); > ( $status ) = CheckReserves($item->{itemnumber}); > is( $status, 'Waiting', 'Now the hold is waiting'); >+ >+ #Bug 21944 - Waiting transfer checked in at branch other than pickup location >+ set_userenv( $library_1 ); >+ (undef, my $messages, undef, undef ) = AddReturn ( $item->{barcode}, $library_1->{branchcode} ); >+ $hold = Koha::Holds->find( $reserve_id ); >+ is( $hold->found, undef, 'Hold is no longer marked waiting' ); >+ is( $hold->priority, 1, "Hold is now priority one again"); >+ is( $messages->{ResFound}->{ResFound}, "Reserved", "Hold is still returned"); >+ is( $messages->{ResFound}->{found}, undef, "Hold is no longer marked found in return message"); >+ is( $messages->{ResFound}->{priority}, 1, "Hold is priority 1 in return message"); >+ > }; > > subtest 'Cancel transfers on lost items' => sub { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21944
:
82848
|
82852
|
83144
|
84752
|
84753
|
84754
|
92609
|
92610
|
94220
|
94221
|
95950
|
95951
|
95952
|
98528
|
98529
|
98530
|
99165
|
99166
|
99167