Bugzilla – Attachment 84845 Details for
Bug 22287
Correct new charts CSS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22287: Correct new charts CSS
Bug-22287-Correct-new-charts-CSS.patch (text/plain), 1.80 KB, created by
Owen Leonard
on 2019-02-07 13:17:49 UTC
(
hide
)
Description:
Bug 22287: Correct new charts CSS
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2019-02-07 13:17:49 UTC
Size:
1.80 KB
patch
obsolete
>From 4d7bc306e7031ebce399c04ed2b5b7178b7acde8 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 7 Feb 2019 13:11:35 +0000 >Subject: [PATCH] Bug 22287: Correct new charts CSS > >This patch reverts some changes to reports CSS from Bug 22168 which were >unnecessary and which adversely affected the report add/edit form >styling. > >To test, apply the patch and clear your browser cache if necessary. > >Go to Reports -> Saved reports and repeat the test plan for Bug 22168: > >- Run a report which returns more than one column. >- On the report results page, click the "Create chart" button. The chart > settings form should appear in a modal window. >- Click the "Draw" button. The modal should disappear and the chart > should be shown. > >Then test the process for adding or editing an SQL report. The form >should be styled in a way consistent with other forms in the staff >client. >--- > koha-tmpl/intranet-tmpl/prog/css/reports.css | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/reports.css b/koha-tmpl/intranet-tmpl/prog/css/reports.css >index 2152cc8..b938b7b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/reports.css >+++ b/koha-tmpl/intranet-tmpl/prog/css/reports.css >@@ -74,23 +74,11 @@ del { > color: #C00; > } > >-fieldset.rows { >- background-color: transparent; >- border: 0; >- font-size: 100%; >- margin: 0; >- padding: 0; >-} >- > fieldset.rows label, > fieldset.rows span.label { > width: 12em; > } > >-fieldset.rows legend { >- margin-left: 0; >-} >- > fieldset.rows .column_config_row { > display: flex; > flex-wrap: wrap; >@@ -108,4 +96,8 @@ fieldset.rows .chart-column-conf label { > margin: .4em 0; > text-align: left; > width: auto; >+} >+ >+#makechart select { >+ max-width: 12em; > } >\ No newline at end of file >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22287
:
84845
|
84892
|
85140