Bugzilla – Attachment 84850 Details for
Bug 7088
Cannot renew items on hold even with override
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7088: (follow-up) Default hold checkbox display
Bug-7088-follow-up-Default-hold-checkbox-display.patch (text/plain), 2.86 KB, created by
Andrew Isherwood
on 2019-02-07 15:44:42 UTC
(
hide
)
Description:
Bug 7088: (follow-up) Default hold checkbox display
Filename:
MIME Type:
Creator:
Andrew Isherwood
Created:
2019-02-07 15:44:42 UTC
Size:
2.86 KB
patch
obsolete
>From 55598c3afec547c1367729f27515ed3507207d11 Mon Sep 17 00:00:00 2001 >From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com> >Date: Thu, 7 Feb 2019 14:43:55 +0000 >Subject: [PATCH] Bug 7088: (follow-up) Default hold checkbox display > >As per item 4 here: >https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088#c24 > >Now, the checkbox for renewing on hold items behaves the same way as the >checkbox for renewing items that have reached their renew limit. It is >necessary to check the re-labelled "Override renewal restrictions" >checkbox before it is possible to select on-hold items for renewal. >--- > koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc | 2 +- > koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 5 +++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc >index 7b4b622762..00c41077e9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/checkouts-table.inc >@@ -41,7 +41,7 @@ > <fieldset class="action"> > [% IF ( CAN_user_circulate_override_renewals ) %] > [% IF CAN_user_circulate_override_renewals && Koha.Preference( 'AllowRenewalLimitOverride' ) %] >- <label for="override_limit">Override renewal limit:</label> >+ <label for="override_limit">Override renewal restrictions:</label> > <input type="checkbox" name="override_limit" id="override_limit" value="1" /> > [% END %] > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >index 7750ceb6a4..4035183a21 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js >@@ -408,11 +408,12 @@ $(document).ready(function() { > if ( oObj.can_renew ) { > // Do nothing > } else if ( oObj.can_renew_error == "on_reserve" ) { >- msg += "<span class='renewals-disabled-no-override'>" >+ msg += "<span>" > + "<a href='/cgi-bin/koha/reserve/request.pl?biblionumber=" + oObj.biblionumber + "'>" + ON_HOLD + "</a>" > + "</span>"; > >- span_style = AllowRenewalLimitOverride ? "" : "display: none"; >+ span_style = "display: none"; >+ span_class = "renewals-allowed"; > } else if ( oObj.can_renew_error == "too_many" ) { > msg += "<span class='renewals-disabled'>" > + NOT_RENEWABLE >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7088
:
79689
|
79690
|
79691
|
82274
|
83004
|
83005
|
83006
|
83092
|
83093
|
83094
|
84509
|
84510
|
84850
|
85434
|
85435
|
85436
|
85437
|
85438
|
85439
|
85440
|
88446
|
88868
|
89026
|
89027
|
89028
|
89029
|
89030
|
89031
|
89032
|
89033
|
89034
|
89044
|
89045
|
89046
|
89047
|
89048
|
89049
|
89050
|
89051
|
89052
|
89086
|
89087
|
89088
|
89089
|
89090
|
89091
|
89092
|
89093
|
89094