Bugzilla – Attachment 84861 Details for
Bug 22294
EDI wrongly assumes all ISBN13's have corresponding ISBN10's
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22294: Check return of as_isbn10 before calling methods on it
Bug-22294-Check-return-of-asisbn10-before-calling-.patch (text/plain), 825 bytes, created by
Martin Renvoize (ashimema)
on 2019-02-08 10:38:54 UTC
(
hide
)
Description:
Bug 22294: Check return of as_isbn10 before calling methods on it
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-02-08 10:38:54 UTC
Size:
825 bytes
patch
obsolete
>From 2dbf98d85354a27493c2ddbd9caeec804fbe0206 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 8 Feb 2019 10:37:50 +0000 >Subject: [PATCH] Bug 22294: Check return of as_isbn10 before calling methods > on it > >--- > Koha/EDI.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/EDI.pm b/Koha/EDI.pm >index 0e632c9294..6cba6d31e2 100644 >--- a/Koha/EDI.pm >+++ b/Koha/EDI.pm >@@ -894,7 +894,7 @@ sub _check_for_existing_bib { > $isbn =~ s/\-//xmsg; > if ( $isbn =~ m/(\d{13})/xms ) { > my $b_isbn = Business::ISBN->new($1); >- if ( $b_isbn && $b_isbn->is_valid ) { >+ if ( $b_isbn && $b_isbn->is_valid && $b_isbn->as_isbn10 ) { > $search_isbn = $b_isbn->as_isbn10->as_string( [] ); > } > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22294
:
84861
|
93668
|
93755