Attachment 84885 Details for Bug 22119 – Bug 22119: Add price formatting in more places in circulation

[patch] Bug 22119: Add price formatting in more places in circulation

Bug-22119-Add-price-formatting-in-more-places-in-c.patch (text/plain), 3.31 KB, created by Martin Renvoize (ashimema) on 2019-02-08 16:48:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-02-08 16:48:29 UTC

Size: 3.31 KB

patch

obsolete

>From 291f97b52d58b4c7d25021b94ee2188ade3bafdb Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sun, 13 Jan 2019 10:06:22 +0100
>Subject: [PATCH] Bug 22119: Add price formatting in more places in circulation
>
>This adds some missing Price filters to some places in circulation.
>To check verify the amount are displayed according to setting
>of CurrencyFormat (use FR or CH for seeing a change)
>
>Use a patron account with no pending fines at the beginning
>for all tests.
>
>1)
>- Switch RentalFeesCheckoutConfirmation to "Ask"
>- Check out an item with a rental charge
>- Verify message is formatted correctly:
>  Rental charge for this item: ...
>
>2)
>- Switch RentalsInNoissuesCharge to "Don't include"
>- Make sure patron has only Rental fines on their account
>- Check out another item
>- Verify message is formatted correctly:
>  The patron has unpaid charges for holds, rentals etc ...
>
>3)
>- Switch BatchCheckouts to "Allow"
>- Add the patron category of your test patron to BatchCheckoutsValidCategories
>- Checkout any item
>- Verify the message in the information column is formatted correctly:
>  The patron has unpaid charges for holds, rentals etc of ...
>
>Signed-off-by: Jasmine Amohia <jasmineamohia.student@wegc.school.nz>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt   | 4 ++--
> .../prog/en/modules/circ/circulation_batch_checkouts.tt       | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index 1d2214764c..a4c2e12ed0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -68,7 +68,7 @@
> [% END %]
> 
> [% IF ( alert.OTHER_CHARGES ) %]
>-    <div class="dialog message">The patron has unpaid charges for holds, rentals etc of [% alert.OTHER_CHARGES | html %]</div>
>+    <div class="dialog message">The patron has unpaid charges for holds, rentals etc of [% alert.OTHER_CHARGES | $Price %]</div>
> [% END %]
> 
> [% IF alert.HIGHHOLDS %]
>@@ -107,7 +107,7 @@
> [% END %]
> 
> [% IF ( RENTALCHARGE && RENTALCHARGE > 0 ) %]
>-    <li>Rental charge for this item: [% RENTALCHARGE | html %]</li>
>+    <li>Rental charge for this item: [% RENTALCHARGE | $Price %]</li>
> [% END %]
> 
> [% IF ( RENEW_ISSUE ) %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt
>index 16a9e3dfe6..c4814ea8e2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt
>@@ -194,7 +194,7 @@
>                       <li>This item has been lost with a status of "[% checkout_info.alert.ITEM_LOST | html %]."</li>
>                   [% END %]
>                   [% IF checkout_info.alert.OTHER_CHARGES %]
>-                      <li>The patron has unpaid charges for holds, rentals etc of [% checkout_info.alert.OTHER_CHARGES | html %].</li>
>+                      <li>The patron has unpaid charges for holds, rentals etc of [% checkout_info.alert.OTHER_CHARGES | $Price %].</li>
>                   [% END %]
>                 </ul>
>               [% END %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22119: 83839 | 83921 | 84885