Attachment 84902 Details for Bug 20102 – Bug 20102: Remove attribute "text/css" for <style> element used in staff client templates

[patch] Bug 20102: Remove attribute "text/css" for <style> element used in staff client templates

Bug-20102-Remove-attribute-textcss-for-style-eleme.patch (text/plain), 18.57 KB, created by José-Mario Monteiro-Santos on 2019-02-08 20:42:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: José-Mario Monteiro-Santos

Created: 2019-02-08 20:42:36 UTC

Size: 18.57 KB

patch

obsolete

>From ab9a0edf22e1ab58fd4def4fadf28a970819caf9 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 29 Nov 2018 17:53:37 +0000
>Subject: [PATCH] Bug 20102: Remove attribute "text/css" for <style> element
> used in staff client templates
>
>This patch modifies staff client templates to remove the "type"
>attribute from <style> tags. The attribute is no longer valid.
>
>To test, apply the patch and confirm the changes to the templates. The
>appearance of the staff client should be unchanged.
>
>Validating pages from the staff client should not return any errors
>related to the <style> "type" attribute.
>
>Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos@inLibro.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc           | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt               | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt          | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt          | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt     | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt          | 2 +-
> .../intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt     | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt           | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt         | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt        | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt      | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt       | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/merge.tt          | 2 +-
> .../en/modules/cataloguing/value_builder/unimarc_field_210c_bis.tt    | 2 +-
> .../intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt    | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt   | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/article-requests.tt      | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt       | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/clubs/templates-add-modify.tt | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt     | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt         | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt        | 4 ++--
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt               | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt              | 4 ++--
> 24 files changed, 26 insertions(+), 26 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc
>index c2d2f48..99cbd60 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc
>@@ -24,7 +24,7 @@
> [% IF ( login ) %]
>     [% Asset.css("css/login.css") | $raw %]
> [% END %]
>-[% IF ( IntranetUserCSS ) %]<style type="text/css">[% IntranetUserCSS | $raw %]</style>[% END %]
>+[% IF ( IntranetUserCSS ) %]<style>[% IntranetUserCSS | $raw %]</style>[% END %]
> 
> [% KohaPlugins.get_plugins_intranet_head | $raw %]
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>index 66ad012..7d2c7b1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>@@ -24,7 +24,7 @@
> <title>Koha &rsaquo; Acquisitions &rsaquo; [% UNLESS ( basketno ) %]New [% END %]Basket [% basketname | html %] ([% basketno | html %]) for [% booksellername | html %]</title>
> [% Asset.css("css/datatables.css") | $raw %]
> [% INCLUDE 'doc-head-close.inc' %]
>-<style type="text/css">
>+<style>
>     .sortmsg {font-size: 80%;}
> </style>
> </head>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
>index 3be27fc..798282e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt
>@@ -17,7 +17,7 @@
> [% Asset.js("lib/yui/animation/animation-min.js") | $raw %]
> [% Asset.js("lib/yui/dragdrop/dragdrop-min.js") | $raw %]
> [% Asset.js("lib/yui/element/element-min.js") | $raw %]
>-<style type="text/css">
>+<style>
> /*margin and padding on body element
>   can introduce errors in determining
>   element position and are not recommended;
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
>index 881094f..81fface 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt
>@@ -5,7 +5,7 @@
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Search for vendor [% supplier | html %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
>-<style type="text/css">
>+<style>
> #vendors td{
> 	vertical-align: top;
> }
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt
>index d15f259..28ea6d7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt
>@@ -11,7 +11,7 @@ Basket [% basket.basketno | html %] &rsaquo; Duplicate existing orders
> </title>
> [% INCLUDE 'doc-head-close.inc' %]
> [% Asset.css("css/datatables.css") | $raw %]
>-<style type="text/css">
>+<style>
>     .picked_to_duplicate > td { background-color: #bcdb89 !important; }
>     span.hint { margin-left: 1em; }
> </style>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt
>index 5700d68..c78e29f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/edifactmsgs.tt
>@@ -6,7 +6,7 @@
> <title>Koha &rsaquo; Acquisitions &rsaquo; EDIFACT messages</title>
> [% Asset.css("css/datatables.css") | $raw %]
> [% INCLUDE 'doc-head-close.inc' %]
>-<style type="text/css">
>+<style>
> #EDI_modal { width : 80%; } @media (max-width: 767px) { #EDI_modal { margin: 0; width : auto; } }
> </style>
> </head>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt
>index 82d1ab8..5aa9404 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt
>@@ -6,7 +6,7 @@
> <title>Koha &rsaquo; Administration &rsaquo; Library checkin and transfer policy</title>
> [% INCLUDE 'doc-head-close.inc' %]
> [% Asset.css("css/datatables.css") | $raw %]
>-<style type="text/css">td { text-align: center; } .sorted { min-width: 50%; }</style>
>+<style>td { text-align: center; } .sorted { min-width: 50%; }</style>
> </head>
> 
> <body id="admin_branch_transfer_limits" class="admin">
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt
>index d50e406..d1b3dc8 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt
>@@ -11,7 +11,7 @@
> </title>
> [% INCLUDE 'doc-head-close.inc' %]
> [% Asset.css("css/datatables.css") | $raw %]
>-<style type="text/css">#enrolmentmessage.hint { display : none; }</style>
>+<style>#enrolmentmessage.hint { display : none; }</style>
> </head>
> 
> <body id="admin_categorie" class="admin">
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt
>index 7e8572a..13abe91 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt
>@@ -16,7 +16,7 @@
> 
> </title>
> [% INCLUDE 'doc-head-close.inc' %]
>-<style type="text/css">
>+<style>
>     #button_add,
>     .split_regex,
>     .split_callnumber
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt
>index 7151a77..e72a3c9 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/batch/print-notices.tt
>@@ -2,7 +2,7 @@
> [% USE raw %]
>     <title>Print Notices for [% today | html %]</title>
>     <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
>-    <style type="text/css">
>+    <style>
>         
> </head>
> <body id="tools_batchMod-del" class="tools">
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>index 049a92f..78ebc4f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>@@ -40,9 +40,9 @@ $(document).ready(function(){
> //]]>
> </script>
> 
>-<style type="text/css">input[type=checkbox]{ margin : 0 .5em; }</style>
>+<style>input[type=checkbox]{ margin : 0 .5em; }</style>
> [% Asset.css("css/addbiblio.css") | $raw %]
> 
> [% INCLUDE 'select2.inc' %]
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
>index 1fea75f..062a05b 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt
>@@ -7,7 +7,7 @@
> [% INCLUDE 'doc-head-open.inc' %]
> <title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %] catalog &rsaquo; Your cart</title>
> [% INCLUDE 'doc-head-close.inc' %]
>-[% BLOCK cssinclude %]<style type="text/css">.item-status, .dt-buttons { display: inline; } @media print { body { height: 99%; } }</style>[% END %]
>+[% BLOCK cssinclude %]<style>.item-status, .dt-buttons { display: inline; } @media print { body { height: 99%; } }</style>[% END %]
> </head>
> [% INCLUDE 'bodytag.inc' bodyid='basket' %]
>     <div class="main">
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt
>index d9fb7a5..e8e5c2d 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt
>@@ -34,8 +34,8 @@
> [% Asset.css("lib/jquery/jquery-ui.css") | $raw %]
> [% Asset.css("lib/font-awesome/css/font-awesome.min.css") | $raw %]
> [% Asset.css("css/sci.css") | $raw %]
>-[% IF ( Koha.Preference('OPACUserCSS') ) %]<style type="text/css">[% Koha.Preference('OPACUserCSS') | $raw %]</style>[% END %]
>-[% IF ( Koha.Preference('SelfCheckInUserCSS') ) %]<style type="text/css">[% Koha.Preference('SelfCheckInUserCSS') | $raw %]</style>[% END %]
>+[% IF ( Koha.Preference('OPACUserCSS') ) %]<style>[% Koha.Preference('OPACUserCSS') | $raw %]</style>[% END %]
>+[% IF ( Koha.Preference('SelfCheckInUserCSS') ) %]<style>[% Koha.Preference('SelfCheckInUserCSS') | $raw %]</style>[% END %]
> 
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 20102: 82759 | 84703 | 84902 | 84905