Attachment 84904 Details for Bug 22293 – Bug 22293: Sticky toolbar making vendor form uneditable

[patch] Bug 22293: Sticky toolbar making vendor form uneditable

Bug-22293-Sticky-toolbar-making-vendor-form-unedit.patch (text/plain), 1.86 KB, created by Mikaël Olangcay Brisebois on 2019-02-08 21:08:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mikaël Olangcay Brisebois

Created: 2019-02-08 21:08:01 UTC

Size: 1.86 KB

patch

obsolete

>From 638928be850fb291e8c42c7ee94059691c8c6d58 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 8 Feb 2019 12:52:48 +0000
>Subject: [PATCH] Bug 22293: Sticky toolbar making vendor form uneditable
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>The new floating toolbar plugin doesn't like a particular combination of
>markup: A toolbar inside a form which is styled "display:inline." The
>staff client CSS styles forms that way globally, so it must be
>explicitly overridden in these situations.
>
>Changing the default will have broad consequences, so I propose an
>inline style to fix this.
>
>To test, apply the patch and go to Acquisitions. Add or edit a vendor
>and confirm that after scrolling down the page the form is still
>editable.
>
>Signed-off-by: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Signed-off-by: MikaÃ«l Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt
>index 8b136370f8..626417dc8f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt
>@@ -114,7 +114,7 @@
>     [% END %]
> [% UNLESS ( enter ) %][% INCLUDE 'acquisitions-toolbar.inc' %][% END %]
> [% IF ( enter ) %]
>-    <form action="updatesupplier.pl" name="updatesupplier" class="validated" method="post">
>+    <form action="updatesupplier.pl" name="updatesupplier" style="display:block" class="validated" method="post">
>         <div id="toolbar" class="btn-toolbar">
>             <button class="btn btn-default btn-sm" type="submit"><i class="fa fa-save"></i> Save</button>
>             [% IF ( booksellerid ) %]
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 22293: 84864 | 84865 | 84904 | 84908