Attachment 84931 Details for Bug 20581 – Bug 20581: (follow-up) Passed value to status_alias

[patch] Bug 20581: (follow-up) Passed value to status_alias

Bug-20581-follow-up-Passed-value-to-statusalias.patch (text/plain), 1.42 KB, created by Katrin Fischer on 2019-02-09 21:54:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2019-02-09 21:54:06 UTC

Size: 1.42 KB

patch

obsolete

>From 0452d1c3b8651b9ded7e795779fad142866dd604 Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Thu, 7 Feb 2019 10:43:51 +0000
>Subject: [PATCH] Bug 20581: (follow-up) Passed value to status_alias
>
>Now we have overloaded status_alias, we can no longer pass it undef (as
>it uses that to determine if it's being used as a getter or setter). So
>we now pass it -1 to indicate it should actually be setting undef (a
>hack, I know, but what are you going to do...)
>
>This patch makes sure ill-request.pl conforms to that. It also fixes the
>testing of the passed parameter, which was wrong.
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> ill/ill-requests.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/ill/ill-requests.pl b/ill/ill-requests.pl
>index acbdda29c8..d6be5c89b2 100755
>--- a/ill/ill-requests.pl
>+++ b/ill/ill-requests.pl
>@@ -174,9 +174,9 @@ if ( $backends_available ) {
>             $request->price_paid($params->{price_paid});
>             $request->notesopac($params->{notesopac});
>             $request->notesstaff($params->{notesstaff});
>-            my $alias = ($params->{status_alias}) ?
>+            my $alias = (length $params->{status_alias} > 0) ?
>                 $params->{status_alias} :
>-                undef;
>+                "-1";
>             $request->status_alias($alias);
>             $request->store;
>             my $backend_result = {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20581: 74323 | 74324 | 74325 | 74326 | 74327 | 74362 | 75333 | 75334 | 75810 | 77819 | 77820 | 77821 | 77822 | 77823 | 77824 | 77825 | 77826 | 78376 | 78377 | 78378 | 78379 | 78380 | 78381 | 78382 | 78383 | 78384 | 78431 | 78515 | 78516 | 78517 | 78518 | 78519 | 78520 | 78521 | 78522 | 78523 | 80279 | 80280 | 80281 | 80282 | 80283 | 80284 | 80285 | 80286 | 80474 | 80475 | 80501 | 80503 | 80505 | 80598 | 80599 | 80600 | 82063 | 82064 | 82065 | 82066 | 82067 | 82068 | 82069 | 82070 | 82071 | 82072 | 82073 | 82074 | 82075 | 82076 | 82443 | 82444 | 82445 | 82446 | 82447 | 82448 | 82449 | 82450 | 82451 | 82452 | 82453 | 82454 | 82455 | 82456 | 82457 | 82458 | 82459 | 82460 | 82461 | 82462 | 82463 | 82464 | 82465 | 82466 | 82467 | 82468 | 82472 | 82483 | 82484 | 82485 | 82486 | 82487 | 82488 | 82489 | 82490 | 82491 | 82492 | 82493 | 82494 | 82495 | 82496 | 82733 | 84202 | 84404 | 84768 | 84770 | 84771 | 84772 | 84773 | 84774 | 84775 | 84776 | 84777 | 84778 | 84779 | 84780 | 84781 | 84782 | 84783 | 84784 | 84785 | 84791 | 84814 | 84818 | 84819 | 84844 | 84911 | 84912 | 84913 | 84914 | 84915 | 84916 | 84917 | 84918 | 84919 | 84920 | 84921 | 84922 | 84923 | 84924 | 84925 | 84926 | 84927 | 84928 | 84929 | 84930 | 84931 | 84964 | 85075 | 85076 | 85077 | 85078 | 85079 | 85080 | 85081 | 85082 | 85083 | 85084 | 85085 | 85086 | 85087 | 85088 | 85089 | 85090 | 85091 | 85092 | 85093 | 85094 | 85095 | 85096