Bugzilla – Attachment 85011 Details for
Bug 10659
Upgrade jQuery star ratings plugin
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10659: (follow-up) Ensure zero rating shows correctly
Bug-10659-follow-up-Ensure-zero-rating-shows-corre.patch (text/plain), 2.60 KB, created by
Katrin Fischer
on 2019-02-12 07:01:26 UTC
(
hide
)
Description:
Bug 10659: (follow-up) Ensure zero rating shows correctly
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2019-02-12 07:01:26 UTC
Size:
2.60 KB
patch
obsolete
>From c82b7e5630f5239f42037ee363166444bfc469b1 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 11 Feb 2019 13:35:12 +0000 >Subject: [PATCH] Bug 10659: (follow-up) Ensure zero rating shows correctly > >This patch makes a minor markup addition to ensure that a title with no >rating shows no stars. > >Also changed: Minor addition to search results JS to prevent unwanted >scrolling if the user clicks a star in a star rating. >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 5 ++++- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 4 ++++ > 2 files changed, 8 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 05ff1bc4c9..46c1c76cb1 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -477,11 +477,14 @@ > [% ELSE %] > <select id="star_rating" name="rating" data-rating-enabled="0" disabled="disabled" autocomplete="off"> > [% END %] >+ [% IF ( rating_avg_int == 0 ) %] >+ <option value="" selected="selected"></option> >+ [% END %] > [% FOREACH i IN [ 1 2 3 4 5 ] %] > [% IF rating_avg_int == i %] > <option value="[% i | html %]" selected="selected">[% i | html %]</option> > [% ELSE %] >- <option value"[% i | html %]">[% i | html %]</option> >+ <option value="[% i | html %]">[% i | html %]</option> > [% END %] > [% END %] > </select> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index c4af74537d..20f0f1c6fc 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -738,6 +738,10 @@ $(document).ready(function(){ > }); > enableCheckboxActions(); > >+ $(".br-readonly a").on("click", function(e){ >+ e.preventDefault(); >+ }); >+ > [% IF ( IDreamBooksResults ) %] > $('.idbresult').each(function() { > var isbn = $(this).children('a').text().replace(/\s*/,''); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10659
:
76049
|
76050
|
76051
|
76487
|
76488
|
76489
|
77740
|
77741
|
82760
|
82826
|
84706
|
84903
|
84970
|
85010
| 85011