Attachment 85020 Details for Bug 20544 – Bug 20544: Wrong comment database documentation on itemnotes

[patch] Bug 20544: Wrong comment database documentation on itemnotes

Bug-20544-Wrong-comment-database-documentation-on-.patch (text/plain), 2.71 KB, created by Martin Renvoize (ashimema) on 2019-02-12 14:05:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-02-12 14:05:22 UTC

Size: 2.71 KB

patch

obsolete

>From 73f1d68a9f1812e60224d383f269bcb11f416baa Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sun, 10 Feb 2019 01:36:20 +0100
>Subject: [PATCH] Bug 20544: Wrong comment database documentation on itemnotes
>
>Fixes the comments in kohastructure.sql to state the right
>MARC21 fields for itemnotes (public and internal).
>
>To test:
>- Create a new Koha database and make sure it still installs
>- Read the patch and check comments are correct
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> installer/data/mysql/kohastructure.sql | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index 89e71c94a5..e91282bd60 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -679,8 +679,8 @@ CREATE TABLE `deleteditems` (
>   `renewals` smallint(6) default NULL, -- number of times this item has been renewed
>   `reserves` smallint(6) default NULL, -- number of times this item has been placed on hold/reserved
>   `restricted` tinyint(1) default NULL, -- authorized value defining use restrictions for this item (MARC21 952$5)
>-  `itemnotes` LONGTEXT, -- public notes on this item (MARC21 952$x)
>-  `itemnotes_nonpublic` LONGTEXT default NULL,
>+  `itemnotes` LONGTEXT, -- public notes on this item (MARC21 952$z)
>+  `itemnotes_nonpublic` LONGTEXT default NULL, -- non-public notes on this item (MARC21 952$x)
>   `holdingbranch` varchar(10) default NULL, -- foreign key from the branches table for the library that is currently in possession item (MARC21 952$b)
>   `paidfor` LONGTEXT,
>   `timestamp` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, -- date and time this item was last altered
>@@ -942,8 +942,8 @@ CREATE TABLE `items` ( -- holdings/item information
>   `renewals` smallint(6) default NULL, -- number of times this item has been renewed
>   `reserves` smallint(6) default NULL, -- number of times this item has been placed on hold/reserved
>   `restricted` tinyint(1) default NULL, -- authorized value defining use restrictions for this item (MARC21 952$5)
>-  `itemnotes` LONGTEXT, -- public notes on this item (MARC21 952$x)
>-  `itemnotes_nonpublic` LONGTEXT default NULL,
>+  `itemnotes` LONGTEXT, -- public notes on this item (MARC21 952$z)
>+  `itemnotes_nonpublic` LONGTEXT default NULL, -- non-public notes on this item (MARC21 952$x)
>   `holdingbranch` varchar(10) default NULL, -- foreign key from the branches table for the library that is currently in possession item (MARC21 952$b)
>   `paidfor` LONGTEXT,
>   `timestamp` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP, -- date and time this item was last altered
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 20544: 84941 | 85020 | 85025