Attachment 85048 Details for Bug 20600 – Bug 20600: (follow-up) Fix tests

[patch] Bug 20600: (follow-up) Fix tests

Bug-20600-follow-up-Fix-tests.patch (text/plain), 2.20 KB, created by Andrew Isherwood on 2019-02-13 09:18:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Isherwood

Created: 2019-02-13 09:18:35 UTC

Size: 2.20 KB

patch

obsolete

>From 64ac41c5ce0baa11e390a71af5150215143a006f Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Mon, 14 Jan 2019 10:41:34 +0000
>Subject: [PATCH] Bug 20600: (follow-up) Fix tests
>
>Some silly variable name typos in the tests
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> t/db_dependent/api/v1/illrequests.t | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
>diff --git a/t/db_dependent/api/v1/illrequests.t b/t/db_dependent/api/v1/illrequests.t
>index 91fa544d2d..59a6bc58d8 100644
>--- a/t/db_dependent/api/v1/illrequests.t
>+++ b/t/db_dependent/api/v1/illrequests.t
>@@ -99,7 +99,7 @@ subtest 'list() tests' => sub {
>     my $response = $illrequest->unblessed;
>     $response->{id_prefix} = $illrequest->id_prefix;
> 
>-    my $req_formatted = add_formatted($illrequest);
>+    my $req_formatted = add_formatted($response);
> 
>     # One illrequest created, should get returned
>     $tx = $t->ua->build_tx( GET => '/api/v1/illrequests' );
>@@ -134,7 +134,7 @@ subtest 'list() tests' => sub {
>     my $response2 = $illrequest2->unblessed;
>     $response2->{id_prefix} = $illrequest2->id_prefix;
> 
>-    my $req2_formatted = add_formatted($illrequest2);
>+    my $req2_formatted = add_formatted($response2);
> 
>     # Two illrequest created, should get returned
>     $tx = $t->ua->build_tx( GET => '/api/v1/illrequests' );
>@@ -159,20 +159,19 @@ sub add_formatted {
>     my @format_dates = ( 'placed', 'updated' );
>     # We need to embellish the request with properties that the API
>     # controller calculates on the fly
>-    my $req_unblessed = $req->unblessed;
>     # Create new "formatted" columns for each date column
>     # that needs formatting
>     foreach my $field(@format_dates) {
>-        if (defined $req_unblessed->{$field}) {
>-            $req_unblessed->{$field . "_formatted"} = format_sqldatetime(
>-                $req_unblessed->{$field},
>+        if (defined $req->{$field}) {
>+            $req->{$field . "_formatted"} = format_sqldatetime(
>+                $req->{$field},
>                 undef,
>                 undef,
>                 1
>             );
>         }
>     }
>-    return $req_unblessed;
>+    return $req;
> }
> 
> sub create_user_and_session {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20600: 74640 | 74641 | 75202 | 75276 | 75734 | 75735 | 75753 | 75755 | 75844 | 75845 | 75848 | 75849 | 75850 | 75851 | 75852 | 75853 | 75854 | 75871 | 77691 | 77692 | 77693 | 77694 | 77695 | 77696 | 77697 | 78439 | 78440 | 78441 | 78442 | 78443 | 78444 | 78445 | 78446 | 78463 | 78464 | 78465 | 78466 | 78467 | 78468 | 78469 | 78470 | 79183 | 80468 | 81992 | 81993 | 82032 | 82033 | 82034 | 82035 | 82036 | 82037 | 82038 | 82039 | 82062 | 82170 | 82171 | 82432 | 82433 | 82434 | 82435 | 82436 | 82437 | 82438 | 82439 | 82440 | 82441 | 82442 | 83882 | 83887 | 84736 | 84737 | 84738 | 84739 | 84740 | 84741 | 84742 | 84743 | 84744 | 84745 | 84746 | 84747 | 84748 | 84749 | 85037 | 85038 | 85039 | 85040 | 85041 | 85042 | 85043 | 85044 | 85045 | 85046 | 85047 | 85048 | 85049 | 85050