Attachment 85070 Details for Bug 17229 – Bug 17229: Add unit test for BlockExpiredPatronOpacActions check

[patch] Bug 17229: Add unit test for BlockExpiredPatronOpacActions check

Bug-17229-Add-unit-test-for-BlockExpiredPatronOpac.patch (text/plain), 1.97 KB, created by Arthur Suzuki on 2019-02-14 01:20:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Arthur Suzuki

Created: 2019-02-14 01:20:00 UTC

Size: 1.97 KB

patch

obsolete

>From 3c13eae4ca9e3da19f64314e73fca5bcb0b5db50 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Wed, 31 Aug 2016 15:52:08 +0200
>Subject: [PATCH] Bug 17229: Add unit test for BlockExpiredPatronOpacActions
> check
>
>Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
>---
> t/db_dependent/Holds.t | 23 +++++++++++++++++++++--
> 1 file changed, 21 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t
>index e2066c7a88..8790969e79 100755
>--- a/t/db_dependent/Holds.t
>+++ b/t/db_dependent/Holds.t
>@@ -7,7 +7,7 @@ use t::lib::TestBuilder;
> 
> use C4::Context;
> 
>-use Test::More tests => 57;
>+use Test::More tests => 58;
> use MARC::Record;
> 
> use C4::Biblio;
>@@ -41,7 +41,12 @@ my $dbh     = C4::Context->dbh;
> my $branch_1 = $builder->build({ source => 'Branch' })->{ branchcode };
> my $branch_2 = $builder->build({ source => 'Branch' })->{ branchcode };
> 
>-my $category = $builder->build({ source => 'Category' });
>+my $category = $builder->build({
>+    source => 'Category',
>+    value => {
>+        BlockExpiredPatronOpacActions => -1,
>+    },
>+});
> 
> my $borrowers_count = 5;
> 
>@@ -129,6 +134,19 @@ my $patron = Koha::Patrons->find( $borrowernumbers[0] );
> $holds = $patron->holds;
> is( $holds->next->borrowernumber, $borrowernumbers[0], "Test Koha::Patron->holds");
> 
>+my $expired_borrowernumber = Koha::Patron->new({
>+        firstname =>  'Expired',
>+        surname => 'Patron',
>+        categorycode => $category->{categorycode},
>+        branchcode => $branch_1,
>+    	dateexpiry => '2000-01-01',
>+    })->store->borrowernumber;
>+
>+t::lib::Mocks::mock_preference('BlockExpiredPatronOpacActions', 1);
>+ok(
>+    CanItemBeReserved($expired_borrowernumber, $itemnumber)->{status} eq 'patronExpired',
>+    'Expired patron cannot reserve'
>+);
> 
> $holds = $item->current_holds;
> $first_hold = $holds->next;
>@@ -656,3 +674,4 @@ subtest 'CanItemBeReserved / holds_per_day tests' => sub {
> 
>     $schema->storage->txn_rollback;
> };
>+
>-- 
>2.13.7

Actions: View | Diff | Splinter Review

Attachments on bug 17229: 55059 | 55060 | 62036 | 62037 | 67324 | 67325 | 70682 | 70683 | 72970 | 72971 | 85064 | 85065 | 85066 | 85070 | 85071 | 85072 | 85118 | 85883 | 89760 | 99701 | 99702 | 99703 | 99817 | 99818 | 99819 | 113741 | 113742 | 113743 | 115081 | 115082 | 115083 | 115411 | 115435