Attachment 85113 Details for Bug 20750 – Bug 20750: (follow-up) Remove status_alias test

[patch] Bug 20750: (follow-up) Remove status_alias test

Bug-20750-follow-up-Remove-statusalias-test.patch (text/plain), 1.46 KB, created by Andrew Isherwood on 2019-02-14 13:36:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Isherwood

Created: 2019-02-14 13:36:53 UTC

Size: 1.46 KB

patch

obsolete

>From 737a55426ef0fb8560c3b3ee492ff7bef70a7c00 Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Thu, 14 Feb 2019 13:32:02 +0000
>Subject: [PATCH] Bug 20750: (follow-up) Remove status_alias test
>
>As per item 8) here:
>https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750#c64
>
>This test is now redundant.
>
>We can't test the return of $req->status_alias against the value of
>$req->{status_alias} any more since we've overloaded the status_alias
>method and it won't always return the value of the object's property.
>
>We test the functionality of the status_alias method elsewhere so we're
>still covered.
>---
> t/db_dependent/Illrequests.t | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/t/db_dependent/Illrequests.t b/t/db_dependent/Illrequests.t
>index ffbc98dc4f..9046852b45 100644
>--- a/t/db_dependent/Illrequests.t
>+++ b/t/db_dependent/Illrequests.t
>@@ -39,7 +39,7 @@ use_ok('Koha::Illrequests');
> 
> subtest 'Basic object tests' => sub {
> 
>-    plan tests => 25;
>+    plan tests => 24;
> 
>     $schema->storage->txn_begin;
> 
>@@ -62,8 +62,6 @@ subtest 'Basic object tests' => sub {
>        "Branchcode getter works.");
>     is($illrq_obj->status, $illrq->{status},
>        "Status getter works.");
>-    is($illrq_obj->status_alias, $illrq->{status_alias},
>-       "Status_alias getter works.");
>     is($illrq_obj->placed, $illrq->{placed},
>        "Placed getter works.");
>     is($illrq_obj->replied, $illrq->{replied},
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20750: 75304 | 75326 | 75329 | 75330 | 77757 | 77816 | 77817 | 77818 | 77931 | 79822 | 79823 | 79824 | 80860 | 82082 | 82083 | 82085 | 82096 | 82097 | 82098 | 82099 | 82500 | 82501 | 82502 | 84193 | 84194 | 84195 | 84203 | 84266 | 84497 | 84498 | 84821 | 84823 | 84824 | 84825 | 84826 | 84827 | 84973 | 84974 | 84975 | 84976 | 84977 | 84978 | 84979 | 85097 | 85098 | 85099 | 85101 | 85113 | 85238 | 85266 | 85697 | 85698 | 85699 | 85700 | 85701 | 85702 | 85703 | 85704 | 85705 | 85706 | 85707 | 85708 | 85709 | 85710 | 85756 | 85757 | 85765 | 85826 | 85827 | 85829 | 85830 | 85831 | 85832 | 85833 | 85834 | 85835 | 85836 | 85837 | 85838 | 85839 | 85840 | 85841 | 85842 | 85843 | 85844 | 85845 | 85846 | 85847 | 85848 | 86434 | 86435 | 86436 | 86534 | 86535 | 86536