Bugzilla – Attachment 85159 Details for
Bug 22002
Each message_transport_type in the letters table is showing as a separate notice in Tools > Notices and slips
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[18.05.X] Bug 22002: (bug 21621 follow-up) Re-add GROUP BY in letter.pl and fix it
Bug-22002-bug-21621-follow-up-Re-add-GROUP-BY-in-l.patch (text/plain), 1.68 KB, created by
Jonathan Druart
on 2019-02-15 12:21:28 UTC
(
hide
)
Description:
[18.05.X] Bug 22002: (bug 21621 follow-up) Re-add GROUP BY in letter.pl and fix it
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-02-15 12:21:28 UTC
Size:
1.68 KB
patch
obsolete
>From f7613d241af7a599b66e6413038b8a16947a8dd4 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Sun, 16 Dec 2018 11:02:56 -0300 >Subject: [PATCH] Bug 22002: (bug 21621 follow-up) Re-add GROUP BY in letter.pl > and fix it >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Caused by > commit 0cffb0f7589aa52d65bda9a8a4934790a141f3a0 > Bug 21621: Remove incorrect GROUP BY from tools/letter.pl >The test plan was not complete enough. > >Test plan: >1) Go to Home ⺠Tools ⺠Notices & slips >2) Choose a letter to edit, e.g. PREDUE. Note that there is only a >single row. >3) Click the edit button on the notice. >4) Expand the 'Print' section. Put text into the Message subject and >Message body text areas. >5) Click save, this will take you back to the 'Notices & slips' page. >6) Clone PREDUE for a specific library >7) The 'all libraries' option must list the templates for all libraries, >but without duplicate >8) Select a library in the dropdown list: only the templates for the >given library is listed, without duplicate > >Signed-off-by: Barton Chittenden <barton@bywatersolutions.com> > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > tools/letter.pl | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/tools/letter.pl b/tools/letter.pl >index caaeb0e212..0cc0029394 100755 >--- a/tools/letter.pl >+++ b/tools/letter.pl >@@ -377,6 +377,8 @@ sub retrieve_letters { > } > > $sql .= " WHERE ".join(" AND ", @where) if @where; >+ $sql .= " GROUP BY branchcode,module,code,name,branchname"; >+ > $sql .= " ORDER BY module, code, branchcode"; > > return $dbh->selectall_arrayref($sql, { Slice => {} }, @args); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22002
:
83225
|
83253
|
83368
|
83854
|
83855
| 85159