Attachment 85169 Details for Bug 22130 – Bug 22130: Correct parameter to get authorized value description.

[patch] Bug 22130: Correct parameter to get authorized value description.

Bug-22130-Correct-parameter-to-get-authorized-valu.patch (text/plain), 2.43 KB, created by Owen Leonard on 2019-02-15 13:48:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2019-02-15 13:48:17 UTC

Size: 2.43 KB

patch

obsolete

>From db2c0c804e02b39288caddd2c46af7477ae678ad Mon Sep 17 00:00:00 2001
>From: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
>Date: Mon, 14 Jan 2019 14:02:49 -0500
>Subject: [PATCH] Bug 22130: Correct parameter to get authorized value
> description.
>
>This patch corrects the error that shows an authorized value instead of the obvious description of the document status.
>
>TEST PLAN
>1) In Koha administration, search "BatchCheckouts".
>2) Make sure "BatchCheckouts" is set at "Allow".
>3) Make sure "BatchCheckoutsValidCategories" contains at least one patron category.
>5) Copy the barcode of an item and change the status document so it cannot be loaned.
>4) Choose a patron which belongs to the patron category at 3).
>(their account should not be expired and they should not have active fees preferably)
>5) Go to the patron details page.
>6) Click on "Batch check out".
>7) Enter the item barcode.
>8) Notice a number is in brackets under the column "Information".
>9) Apply patch.
>10) Notice the status description has replaced the number.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> .../intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt   | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt
>index c4814ea..c295ff5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt
>@@ -154,7 +154,7 @@
>                     [% IF checkout_info.itemtype_notforloan %]
>                         <li><i class="fa fa-li fa-warning"></i>Item type is normally not for loan.</li>
>                     [% ELSIF checkout_info.item_notforloan %]
>-                      [% item_notforloan_lib = AuthorisedValues.GetByCode( authvalcode_notforloan, checkout_info.item_notforloan, 0 ) %]
>+                      [% item_notforloan_lib = AuthorisedValues.GetByCode( checkout_info.authvalcode_notforloan, checkout_info.item_notforloan, 0 ) %]
>                         <li><i class="fa fa-li fa-warning"></i>Item is normally not for loan [% IF item_notforloan_lib %]([% item_notforloan_lib | html %])[% END %].</li>
>                     [% END %]
>                   [% END %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 22130: 83986 | 85013 | 85027 | 85028 | 85169 | 85170