Bugzilla – Attachment 85259 Details for
Bug 3820
More detailed patron record changes log
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 3820: Update tests to reflect the change of behaviour
Bug-3820-Update-tests-to-reflect-the-change-of-beh.patch (text/plain), 1.48 KB, created by
Josef Moravec
on 2019-02-18 19:20:25 UTC
(
hide
)
Description:
Bug 3820: Update tests to reflect the change of behaviour
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2019-02-18 19:20:25 UTC
Size:
1.48 KB
patch
obsolete
>From a0ae1bbd4d9cabb31c75c9b0ea13ff771f558c0d Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 18 Feb 2019 13:33:53 +0000 >Subject: [PATCH] Bug 3820: Update tests to reflect the change of behaviour > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > t/db_dependent/Koha/Patrons.t | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t >index 9fdce19..2b8a13d 100644 >--- a/t/db_dependent/Koha/Patrons.t >+++ b/t/db_dependent/Koha/Patrons.t >@@ -1411,9 +1411,9 @@ subtest 'Log cardnumber change' => sub { > > my @logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'MODIFY', object => $patron->borrowernumber } ); > my $log_info = from_json( $logs[0]->info ); >- is( $log_info->{cardnumber_replaced}->{new_cardnumber}, 'TESTCARDNUMBER', 'Got correct new cardnumber' ); >- is( $log_info->{cardnumber_replaced}->{previous_cardnumber}, $cardnumber, 'Got correct old cardnumber' ); >- is( scalar @logs, 2, 'With BorrowerLogs, Change in cardnumber should be logged, as well as general alert of patron mod.' ); >+ is( $log_info->{cardnumber}->{after}, 'TESTCARDNUMBER', 'Got correct new cardnumber' ); >+ is( $log_info->{cardnumber}->{before}, $cardnumber, 'Got correct old cardnumber' ); >+ is( scalar @logs, 1, 'With BorrowerLogs, one detailed MODIFY action should be logged for the modification.' ); > }; > > $schema->storage->txn_rollback; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 3820
:
1584
|
1585
|
85100
|
85102
|
85103
|
85104
|
85161
|
85162
|
85196
|
85197
|
85243
|
85244
|
85245
|
85246
|
85256
|
85257
|
85258
|
85259
|
85260
|
85269
|
85270
|
85271
|
85272
|
85273
|
85274
|
85276
|
85277