Bugzilla – Attachment 85317 Details for
Bug 21875
Handling subject line in Letters.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21875: Handling subject line in Letters.pm
Bug-21875-Handling-subject-line-in-Letterspm.patch (text/plain), 1.61 KB, created by
Martin Renvoize (ashimema)
on 2019-02-20 09:08:10 UTC
(
hide
)
Description:
Bug 21875: Handling subject line in Letters.pm
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2019-02-20 09:08:10 UTC
Size:
1.61 KB
patch
obsolete
>From 565b4c499165f488c74886b73a7ab8c77d3a3aaa Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 23 Nov 2018 11:36:49 +0100 >Subject: [PATCH] Bug 21875: Handling subject line in Letters.pm > >The variable name $utf8 is very misleading: it contains MIME-Header encoding. >$message->{subject} comes from the database and is in perl internal format; >it should NOT be decoded as a MIME-Header. >After encoding to MIME-Header, previously another (useless) encoding to >UTF-8 was done. Since the string is plain ASCII, this is useless and >theoretically wrong. We should stay in MIME-Header. > >Test plan: >See Bugzilla comment5. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Letters.pm | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index bf94c0e2ba..cbe6559e82 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -1284,9 +1284,10 @@ sub _send_message_by_email { > } > } > >- my $utf8 = decode('MIME-Header', $message->{'subject'} ); >- $message->{subject}= encode('MIME-Header', $utf8); >- my $subject = encode('UTF-8', $message->{'subject'}); >+ # Encode subject line separately >+ $message->{subject} = encode('MIME-Header', $message->{'subject'} ); >+ my $subject = $message->{'subject'}; >+ > my $content = encode('UTF-8', $message->{'content'}); > my $content_type = $message->{'content_type'} || 'text/plain; charset="UTF-8"'; > my $is_html = $content_type =~ m/html/io; >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21875
:
82601
|
82611
|
82840
|
82841
|
85139
| 85317