Attachment 85430 Details for Bug 21756 – Bug 21756: (follow-up) Replace newly introduced manualinvoice call

[patch] Bug 21756: (follow-up) Replace newly introduced manualinvoice call

Bug-21756-follow-up-Replace-newly-introduced-manua.patch (text/plain), 1.07 KB, created by Martin Renvoize (ashimema) on 2019-02-21 08:50:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-02-21 08:50:22 UTC

Size: 1.07 KB

patch

obsolete

>From 9b55233c4b4fa29eb1358763f6b5e5f0cb9302af Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 21 Feb 2019 08:47:55 +0000
>Subject: [PATCH] Bug 21756: (follow-up) Replace newly introduced manualinvoice
> call
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/Circulation.t | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t
>index 0c09b11cad..89f5e416d6 100755
>--- a/t/db_dependent/Circulation.t
>+++ b/t/db_dependent/Circulation.t
>@@ -2307,9 +2307,8 @@ subtest '_FixAccountForLostAndReturned' => sub {
>             'Payment applied'
>         );
> 
>-        # TODO use add_debit when time comes
>         my $manual_debit_amount = 80;
>-        C4::Accounts::manualinvoice( $patron->id, undef, undef, 'FU', $manual_debit_amount );
>+        $account->add_debit( { amount => $manual_debit_amount, type => 'fine' } );
> 
>         is( $account->balance, $manual_debit_amount + $replacement_amount - $payment_amount, 'Manual debit applied' );
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 21756: 83257 | 83258 | 83259 | 83260 | 83261 | 83262 | 83263 | 83264 | 83265 | 83266 | 83267 | 83268 | 83269 | 83270 | 83271 | 84729 | 84730 | 84731 | 84732 | 84733 | 85320 | 85321 | 85322 | 85323 | 85324 | 85325 | 85326 | 85327 | 85350 | 85420 | 85421 | 85422 | 85423 | 85424 | 85425 | 85426 | 85427 | 85428 | 85429 | 85430 | 85505 | 85506 | 85507 | 85508 | 85509 | 85510 | 85511 | 85512 | 85513 | 85514 | 85515 | 85638 | 85639 | 85640 | 85641 | 85642 | 85643 | 85644 | 85645 | 85646 | 85647 | 85648 | 85654 | 85655 | 85656 | 85657 | 85658 | 85659 | 85660 | 85661 | 85662 | 85663 | 85664 | 85665 | 86265 | 86266 | 86267 | 86268 | 86269 | 86270 | 86271 | 86272 | 86273 | 86274 | 86275 | 86276 | 86441 | 86442 | 86443 | 86444 | 86445 | 86446 | 86447 | 86448 | 86449 | 86450 | 86451 | 86452