Attachment 85575 Details for Bug 22372 – Bug 22171: Fix shipping cost display on invoice

[patch] Bug 22171: Fix shipping cost display on invoice

Bug-22171-Fix-shipping-cost-display-on-invoice.patch (text/plain), 1.94 KB, created by Bin Wen on 2019-02-22 20:15:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Bin Wen

Created: 2019-02-22 20:15:23 UTC

Size: 1.94 KB

patch

obsolete

>From 7f836c00269567d8ce3aeb6169e3bbdcbb811748 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Tue, 5 Feb 2019 21:29:13 +0000
>Subject: [PATCH] Bug 22171: Fix shipping cost display on invoice
>
>When not 0 the shipping cost on the invoice would display with
>a lot of numbers after the comma. This fixed it to display with
>only 2.
>
>To test:
>- Make sure you have an invoice with shipping cost set (example: 5.00)
>- Open the invoice for editing (invoice.pl)
>- Verify the shipping cost displays with too many decimals (5.000000)
>- Apply patch
>- Verify now the shipping cost displays correctly (5.00)
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>Signed-off-by: bin.wen <bin.wen@inlibro.com>
>
>https://bugs.koha-community.org/show_bug.cgi?id=22372
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>index 5dab779f98..a072677dd1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt
>@@ -47,7 +47,7 @@
>                     <input type="text" size="10" id="billingdate" name="billingdate" value="[% billingdate | $KohaDates %]" class="datepicker" /></li>
> 
>             <li><label for="shipmentcost">Shipping cost:</label>
>-                    <input type="text" size="10" id="shipmentcost" name="shipmentcost" value="[% shipmentcost | html %]" /></li>
>+                    <input type="text" size="10" id="shipmentcost" name="shipmentcost" value="[% shipmentcost | $Price on_editing => 1 %]" /></li>
>             <li><label for="shipment_budget_id">Shipping fund:</label>
>                     <select id="shipment_budget_id" name="shipment_budget_id">
>                         <option value="">No fund</option>
>-- 
>2.17.1

Actions: View | Diff | Splinter Review

Attachments on bug 22372: 85285 | 85575 | 86931 | 87565 | 87566