Attachment 85615 Details for Bug 22378 – Bug 22378: Fix audio alerts on SCO

[patch] Bug 22378: Fix audio alerts on SCO

Bug-22378-Fix-audio-alerts-on-SCO.patch (text/plain), 1.61 KB, created by Josef Moravec on 2019-02-25 13:29:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2019-02-25 13:29:36 UTC

Size: 1.61 KB

patch

obsolete

>From 42b35721669582c39bea1cac05768ca84935a5ca Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 20 Feb 2019 20:00:01 +0000
>Subject: [PATCH] Bug 22378: Fix audio alerts on SCO
>
>Note: The SCO only supports sounds with a full URL, not KOha built in sounds
>
>To test:
>1 - Enable audio alerts
>2 -  Enable SCO
>3 - Note JS error on loading the alerts
>4 - Apply patch
>5 - No more error
>6 - Test with bug 18251
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>index e004afd2b6..2935351f9f 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
>@@ -3,6 +3,7 @@
> [% USE Koha %]
> [% USE KohaDates %]
> [% USE AudioAlerts %]
>+[% USE To %]
> [% USE Price %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha [% END %] &rsaquo; Self checkout </title>
>@@ -379,7 +380,7 @@
>             return true;
>         }
>         [% IF Koha.Preference('AudioAlerts') %]
>-            var AUDIO_ALERTS = JSON.parse( '[% AudioAlerts.AudioAlerts | replace( "'", "\\'" ) | replace( '"', '\\"' ) | html %]' );
>+            var AUDIO_ALERTS = JSON.parse( "[% To.json(AudioAlerts.AudioAlerts) | $raw %]" );
>             $( document ).ready(function() {
>                 if ( AUDIO_ALERTS ) {
>                     for ( var k in AUDIO_ALERTS ) {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22378: 85410 | 85615