Bugzilla – Attachment 8564 Details for
Bug 7773
serials/subscription-add.pl needs to scope $query for plack
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7773 - serials/subscription-add.pl scope for plack
Bug-7773---serialssubscription-addpl-scope-for-pla.patch (text/plain), 1.92 KB, created by
Dobrica Pavlinusic
on 2012-03-23 10:08:02 UTC
(
hide
)
Description:
Bug 7773 - serials/subscription-add.pl scope for plack
Filename:
MIME Type:
Creator:
Dobrica Pavlinusic
Created:
2012-03-23 10:08:02 UTC
Size:
1.92 KB
patch
obsolete
>From 9cb06a2f3c1b539d765523db62ffd85d979d1d66 Mon Sep 17 00:00:00 2001 >From: Dobrica Pavlinusic <dpavlin@rot13.org> >Date: Wed, 21 Mar 2012 11:28:54 +0100 >Subject: [PATCH] Bug 7773 - serials/subscription-add.pl scope for plack > >This fixes scope of $query and $nextexpected >--- > serials/subscription-add.pl | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/serials/subscription-add.pl b/serials/subscription-add.pl >index 9acee7b..4038e1a 100755 >--- a/serials/subscription-add.pl >+++ b/serials/subscription-add.pl >@@ -34,7 +34,7 @@ use Carp; > > #use Smart::Comments; > >-my $query = CGI->new; >+our $query = CGI->new; > my $op = $query->param('op') || ''; > my $dbh = C4::Context->dbh; > my $sub_length; >@@ -64,7 +64,6 @@ my @sub_type_data; > > my $subs; > my $firstissuedate; >-my $nextexpected; > > if ($op eq 'modify' || $op eq 'dup' || $op eq 'modsubscription') { > >@@ -89,7 +88,7 @@ if ($op eq 'modify' || $op eq 'dup' || $op eq 'modsubscription') { > $subs->{letter}= q{}; > } > letter_loop($subs->{'letter'}, $template); >- $nextexpected = GetNextExpected($subscriptionid); >+ my $nextexpected = GetNextExpected($subscriptionid); > $nextexpected->{'isfirstissue'} = $nextexpected->{planneddate}->output('iso') eq $firstissuedate ; > $subs->{nextacquidate} = $nextexpected->{planneddate}->output() if($op eq 'modify'); > unless($op eq 'modsubscription') { >@@ -326,6 +325,7 @@ sub redirect_mod_subscription { > my $opacdisplaycount = $query->param('opacdisplaycount'); > my $graceperiod = $query->param('graceperiod') || 0; > my $location = $query->param('location'); >+ my $nextexpected = GetNextExpected($subscriptionid); > # If it's a mod, we need to check the current 'expected' issue, and mod it in the serials table if necessary. > if ( $nextacquidate ne $nextexpected->{planneddate}->output('iso') ) { > ModNextExpected($subscriptionid,C4::Dates->new($nextacquidate,'iso')); >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7773
:
8394
|
8425
|
8564
|
8571