Attachment 85657 Details for Bug 21756 – Bug 21756: Add deprecation warning to manualinvoice

[patch] Bug 21756: Add deprecation warning to manualinvoice

Bug-21756-Add-deprecation-warning-to-manualinvoice.patch (text/plain), 2.11 KB, created by Josef Moravec on 2019-02-25 18:45:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2019-02-25 18:45:13 UTC

Size: 2.11 KB

patch

obsolete

>From ba63ee018b12c1d4e79770d0394182011f4157d7 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 17 Dec 2018 08:56:53 +0000
>Subject: [PATCH] Bug 21756: Add deprecation warning to manualinvoice
>
>https://bugs.koha-community.org/show_bug.cgi?id=21756
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> C4/Accounts.pm | 24 +++++-------------------
> 1 file changed, 5 insertions(+), 19 deletions(-)
>
>diff --git a/C4/Accounts.pm b/C4/Accounts.pm
>index eb31f6cc46..0339e68f9b 100644
>--- a/C4/Accounts.pm
>+++ b/C4/Accounts.pm
>@@ -29,6 +29,7 @@ use Koha::Account::Lines;
> use Koha::Account::Offsets;
> use Koha::Items;
> 
>+use Mojo::Util qw(deprecated);
> use Data::Dumper qw(Dumper);
> 
> use vars qw(@ISA @EXPORT);
>@@ -37,7 +38,6 @@ BEGIN {
>     require Exporter;
>     @ISA    = qw(Exporter);
>     @EXPORT = qw(
>-      &manualinvoice
>       &getnextacctno
>       &chargelostitem
>       &purge_zero_balance_fees
>@@ -161,29 +161,15 @@ sub chargelostitem{
>   &manualinvoice($borrowernumber, $itemnumber, $description, $type,
>                  $amount, $note);
> 
>-C<$borrowernumber> is the patron's borrower number.
>-C<$description> is a description of the transaction.
>-C<$type> may be one of C<CS>, C<CB>, C<CW>, C<CF>, C<CL>, C<N>, C<L>,
>-or C<REF>.
>-C<$itemnumber> is the item involved, if pertinent; otherwise, it
>-should be the empty string.
>+This function is now deprecated and not used anywhere within koha. It is due for complete removal in 19.11
> 
> =cut
> 
>-#'
>-# FIXME: In Koha 3.0 , the only account adjustment 'types' passed to this function
>-# are:
>-# 		'C' = CREDIT
>-# 		'FOR' = FORGIVEN  (Formerly 'F', but 'F' is taken to mean 'FINE' elsewhere)
>-# 		'N' = New Card fee
>-# 		'F' = Fine
>-# 		'A' = Account Management fee
>-# 		'M' = Sundry
>-# 		'L' = Lost Item
>-#
>-
> sub manualinvoice {
>     my ( $borrowernumber, $itemnum, $desc, $type, $amount, $note ) = @_;
>+
>+    deprecated "C4::Accounts::manualinvoice is deprecated in favor of Koha::Account->add_debit";
>+
>     my $manager_id = 0;
>     $manager_id = C4::Context->userenv->{'number'} if C4::Context->userenv;
>     my $dbh      = C4::Context->dbh;
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21756: 83257 | 83258 | 83259 | 83260 | 83261 | 83262 | 83263 | 83264 | 83265 | 83266 | 83267 | 83268 | 83269 | 83270 | 83271 | 84729 | 84730 | 84731 | 84732 | 84733 | 85320 | 85321 | 85322 | 85323 | 85324 | 85325 | 85326 | 85327 | 85350 | 85420 | 85421 | 85422 | 85423 | 85424 | 85425 | 85426 | 85427 | 85428 | 85429 | 85430 | 85505 | 85506 | 85507 | 85508 | 85509 | 85510 | 85511 | 85512 | 85513 | 85514 | 85515 | 85638 | 85639 | 85640 | 85641 | 85642 | 85643 | 85644 | 85645 | 85646 | 85647 | 85648 | 85654 | 85655 | 85656 | 85657 | 85658 | 85659 | 85660 | 85661 | 85662 | 85663 | 85664 | 85665 | 86265 | 86266 | 86267 | 86268 | 86269 | 86270 | 86271 | 86272 | 86273 | 86274 | 86275 | 86276 | 86441 | 86442 | 86443 | 86444 | 86445 | 86446 | 86447 | 86448 | 86449 | 86450 | 86451 | 86452