Bugzilla – Attachment 85661 Details for
Bug 21756
Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21756: (follow-up) Add test for deprecation warning
Bug-21756-follow-up-Add-test-for-deprecation-warni.patch (text/plain), 1.36 KB, created by
Josef Moravec
on 2019-02-25 18:45:29 UTC
(
hide
)
Description:
Bug 21756: (follow-up) Add test for deprecation warning
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2019-02-25 18:45:29 UTC
Size:
1.36 KB
patch
obsolete
>From 59d35bbc02144498c9cd8a1f275bf5e63b9c4b8f Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Thu, 21 Feb 2019 08:41:29 +0000 >Subject: [PATCH] Bug 21756: (follow-up) Add test for deprecation warning > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > t/db_dependent/Accounts.t | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Accounts.t b/t/db_dependent/Accounts.t >index 921b4bc4b9..2dfe97b1e7 100644 >--- a/t/db_dependent/Accounts.t >+++ b/t/db_dependent/Accounts.t >@@ -18,7 +18,7 @@ > > use Modern::Perl; > >-use Test::More tests => 33; >+use Test::More tests => 34; > use Test::MockModule; > use Test::Warn; > >@@ -79,7 +79,12 @@ my $amount = '5.000000'; > my $description = "Test fee!"; > my $type = 'L'; > my $note = 'Test note!'; >-manualinvoice( $patron->{borrowernumber}, $item->{itemnumber}, $description, $type, $amount, $note ); >+warning_like { >+ C4::Accounts::manualinvoice( $patron->{borrowernumber}, >+ $item->{itemnumber}, $description, $type, $amount, $note ) >+} >+qr/C4::Accounts::manualinvoice is deprecated in favor of Koha::Account->add_debit/, >+ "deprecation warning recieved for manualinvoice"; > my ($accountline) = Koha::Account::Lines->search( > { > borrowernumber => $patron->{borrowernumber} >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21756
:
83257
|
83258
|
83259
|
83260
|
83261
|
83262
|
83263
|
83264
|
83265
|
83266
|
83267
|
83268
|
83269
|
83270
|
83271
|
84729
|
84730
|
84731
|
84732
|
84733
|
85320
|
85321
|
85322
|
85323
|
85324
|
85325
|
85326
|
85327
|
85350
|
85420
|
85421
|
85422
|
85423
|
85424
|
85425
|
85426
|
85427
|
85428
|
85429
|
85430
|
85505
|
85506
|
85507
|
85508
|
85509
|
85510
|
85511
|
85512
|
85513
|
85514
|
85515
|
85638
|
85639
|
85640
|
85641
|
85642
|
85643
|
85644
|
85645
|
85646
|
85647
|
85648
|
85654
|
85655
|
85656
|
85657
|
85658
|
85659
|
85660
|
85661
|
85662
|
85663
|
85664
|
85665
|
86265
|
86266
|
86267
|
86268
|
86269
|
86270
|
86271
|
86272
|
86273
|
86274
|
86275
|
86276
|
86441
|
86442
|
86443
|
86444
|
86445
|
86446
|
86447
|
86448
|
86449
|
86450
|
86451
|
86452