Attachment 85721 Details for Bug 22404 – Bug 22404: Fix parameter "for" of labels in subscription add form

[patch] Bug 22404: Fix parameter "for" of labels in subscription add form

Bug-22404-Fix-parameter-for-of-labels-in-subscript.patch (text/plain), 3.18 KB, created by Biblibre Sandboxes on 2019-02-26 14:26:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Biblibre Sandboxes

Created: 2019-02-26 14:26:34 UTC

Size: 3.18 KB

patch

obsolete

>From a1acd6683c0545e57c5942536c981aa5dde91157 Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Mon, 25 Feb 2019 08:46:11 +0000
>Subject: [PATCH] Bug 22404: Fix parameter "for" of labels in subscription add
> form
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Attribute "for" of tag labelshould contain input id, not name.
>
>Test plan:
>1) Go to serials -> add subscription second step
>2) Click on labels of these three fields:
>    - First issue publication date
>    - Subscription start date
>    - Subscription end date
>
>--> without patch, nothing happen
>--> with path, the datepicker is shown
>
>Signed-off-by: SÃ©verine QUEUNE <severine.queune@bulac.fr>
>Signed-off-by: SÃ©verine QUEUNE <severine.queune@bulac.fr>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>index 7fb822e..714bd75 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt
>@@ -224,7 +224,7 @@ fieldset.rows li.radio { width: 100%; } /* override staff-global.css */
>                                 <legend>Serials planning</legend>
>                                 <ol>
>                                     <li>
>-                                        <label for="firstacquidate" class="required">First issue publication date:</label>
>+                                        <label for="acqui_date" class="required">First issue publication date:</label>
>                                         [% UNLESS (more_than_one_serial) %]
>                                           <input type="text" size="10" id="acqui_date" name="firstacquidate" value="[% firstacquidate | $KohaDates %]" class="datepicker required" required="required" />
>                                         [% ELSE %]
>@@ -288,11 +288,11 @@ fieldset.rows li.radio { width: 100%; } /* override staff-global.css */
>                                         <input type="hidden" name="issuelengthcount">
>                                     </li>
>                                     <li>
>-                                        <label for="startdate" class="required"> Subscription start date:</label>
>+                                        <label for="from" class="required"> Subscription start date:</label>
>                                         <input type="text" size="10" id="from" name="startdate" value="[% startdate | $KohaDates %]" class="datepickerfrom required" required="required" />
>                                     </li>
>                                     <li>
>-                                        <label for="enddate">Subscription end date:</label>
>+                                        <label for="to">Subscription end date:</label>
>                                         <input type="text" size="10" id="to" name="enddate" value="[% enddate | $KohaDates %]" class="datepickerto" />
>                                     </li>
>                                     <li>
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 22404: 85593 | 85721 | 85805