Bugzilla – Attachment 85740 Details for
Bug 21846
Using emoji as tags doesn't discriminate between emoji when calculating weights or searching
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21846: Fix pod2usage return values
Bug-21846-Fix-pod2usage-return-values.patch (text/plain), 1.02 KB, created by
Jonathan Druart
on 2019-02-26 20:03:01 UTC
(
hide
)
Description:
Bug 21846: Fix pod2usage return values
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-02-26 20:03:01 UTC
Size:
1.02 KB
patch
obsolete
>From c7210f455559310efc0b182fafbc1061b8f75e10 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 26 Feb 2019 16:32:44 -0300 >Subject: [PATCH] Bug 21846: Fix pod2usage return values > >According to existing pattern. >However I am not sure it makes sense to return an errno (and print to STDERR) >if --help is passed. >--- > misc/maintenance/fix_tags_weight.pl | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > >diff --git a/misc/maintenance/fix_tags_weight.pl b/misc/maintenance/fix_tags_weight.pl >index 549d170614..7dc3801c16 100755 >--- a/misc/maintenance/fix_tags_weight.pl >+++ b/misc/maintenance/fix_tags_weight.pl >@@ -65,15 +65,12 @@ binmode( STDOUT, ":encoding(UTF-8)" ); > my $help; > my $verbose; > >-my $result = GetOptions( >+GetOptions( > 'help|h' => \$help, > 'verbose|v' => \$verbose >-); >+) or pod2usage(2); > >-if ( not $result or $help ) { >- pod2usage(); >- exit 0; >-} >+pod2usage(1) if $help; > > fix_tags_approval($verbose); > fix_tags_index( $verbose ); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21846
:
82621
|
82622
|
82623
|
83717
|
83759
|
83760
|
83761
|
83762
|
85730
|
85740
|
85741
|
85758
|
85759
|
85760
|
85761
|
85762
|
85763
|
85764