Bugzilla – Attachment 85945 Details for
Bug 18925
Move maxissueqty and maxonsiteissueqty to circulation_rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18925: Update new occurrences
Bug-18925-Update-new-occurrences.patch (text/plain), 2.96 KB, created by
Tomás Cohen Arazi (tcohen)
on 2019-03-02 13:40:27 UTC
(
hide
)
Description:
Bug 18925: Update new occurrences
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2019-03-02 13:40:27 UTC
Size:
2.96 KB
patch
obsolete
>From 9bc73bbebfb84c8f4313530a690837e1f968cc04 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 21 Feb 2019 17:04:38 -0300 >Subject: [PATCH] Bug 18925: Update new occurrences > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/Circulation/TooMany.t | 21 +++++++++++-------- > .../Holds/DisallowHoldIfItemsAvailable.t | 3 +-- > 2 files changed, 13 insertions(+), 11 deletions(-) > >diff --git a/t/db_dependent/Circulation/TooMany.t b/t/db_dependent/Circulation/TooMany.t >index 581a010e18..47263a9865 100644 >--- a/t/db_dependent/Circulation/TooMany.t >+++ b/t/db_dependent/Circulation/TooMany.t >@@ -163,16 +163,19 @@ subtest '1 Issuingrule exist 0 0: no issue allowed' => sub { > > subtest '1 Issuingrule exist with onsiteissueqty=unlimited' => sub { > plan tests => 4; >- my $issuingrule = $builder->build({ >- source => 'Issuingrule', >- value => { >- branchcode => $branch->{branchcode}, >- categorycode => $category->{categorycode}, >- itemtype => '*', >- maxissueqty => 1, >- maxonsiteissueqty => undef, >+ >+ Koha::CirculationRules->set_rules( >+ { >+ branchcode => $branch->{branchcode}, >+ categorycode => $category->{categorycode}, >+ itemtype => '*', >+ rules => { >+ maxissueqty => 1, >+ maxonsiteissueqty => undef, >+ } > }, >- }); >+ ); >+ > my $issue = C4::Circulation::AddIssue( $patron, $item->{barcode}, dt_from_string() ); > t::lib::Mocks::mock_preference('ConsiderOnSiteCheckoutsAsNormalCheckouts', 0); > is_deeply( >diff --git a/t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t b/t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t >index 647460d1f6..255c757bf6 100755 >--- a/t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t >+++ b/t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t >@@ -127,7 +127,7 @@ AddReturn( $item1->{barcode} ); > my $hold_allowed_from_home_library = 1; > my $hold_allowed_from_any_libraries = 2; > my $sth_delete_rules = $dbh->prepare(q|DELETE FROM default_circ_rules|); >- my $sth_insert_rule = $dbh->prepare(q|INSERT INTO default_circ_rules(singleton, maxissueqty, maxonsiteissueqty, holdallowed, hold_fulfillment_policy, returnbranch) VALUES ('singleton', NULL, NULL, ?, 'any', 'homebranch');|); >+ my $sth_insert_rule = $dbh->prepare(q|INSERT INTO default_circ_rules(singleton, holdallowed, hold_fulfillment_policy, returnbranch) VALUES ('singleton', ?, 'any', 'homebranch');|); > > subtest 'Item is available at a different library' => sub { > plan tests => 4; >@@ -243,7 +243,6 @@ $rule = Koha::IssuingRule->new( > categorycode => '*', > itemtype => '*', > branchcode => '*', >- maxissueqty => 99, > issuelength => 7, > lengthunit => 8, > reservesallowed => 99, >-- >2.21.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18925
:
65238
|
65239
|
65240
|
67024
|
67025
|
67026
|
67621
|
70992
|
70993
|
70994
|
70995
|
70996
|
71032
|
71033
|
71043
|
71044
|
71045
|
71046
|
71047
|
72225
|
72226
|
72227
|
72228
|
72229
|
77225
|
77226
|
77227
|
77228
|
77229
|
78881
|
78882
|
78883
|
78884
|
78885
|
78886
|
79642
|
79643
|
79644
|
79645
|
79646
|
81091
|
81092
|
81093
|
81094
|
81095
|
82927
|
82928
|
82929
|
82930
|
82931
|
85480
|
85481
|
85482
|
85483
|
85484
|
85485
|
85486
|
85939
|
85940
|
85941
|
85942
|
85943
|
85944
|
85945
|
85946
|
85947
|
85948
|
85949
|
85950
|
85951
|
85953
|
85954
|
85955
|
85956
|
85957
|
85958
|
85959
|
85960
|
85961
|
85962
|
85963
|
85964
|
85965
|
86068
|
86069
|
86070
|
86071
|
86072
|
86073
|
86074
|
86075
|
86076
|
86077
|
86078
|
86079
|
86080
|
86081
|
86121
|
86165
|
86206
|
86207