Bugzilla – Attachment 85946 Details for
Bug 18925
Move maxissueqty and maxonsiteissueqty to circulation_rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18925: (QA follow-up) Make DB update idempotent
Bug-18925-QA-follow-up-Make-DB-update-idempotent.patch (text/plain), 3.86 KB, created by
Tomás Cohen Arazi (tcohen)
on 2019-03-02 13:40:38 UTC
(
hide
)
Description:
Bug 18925: (QA follow-up) Make DB update idempotent
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2019-03-02 13:40:38 UTC
Size:
3.86 KB
patch
obsolete
>From eb0d49e3faec2ca9256e784eb447511690426391 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Sat, 2 Mar 2019 10:14:48 -0300 >Subject: [PATCH] Bug 18925: (QA follow-up) Make DB update idempotent > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > .../data/mysql/atomicupdate/bug_18925.perl | 52 ++++++++++--------- > 1 file changed, 28 insertions(+), 24 deletions(-) > >diff --git a/installer/data/mysql/atomicupdate/bug_18925.perl b/installer/data/mysql/atomicupdate/bug_18925.perl >index 3e5075fbe5..89d943f597 100644 >--- a/installer/data/mysql/atomicupdate/bug_18925.perl >+++ b/installer/data/mysql/atomicupdate/bug_18925.perl >@@ -1,31 +1,35 @@ > $DBversion = 'XXX'; # will be replaced by the RM > if( CheckVersion( $DBversion ) ) { >- if ( column_exists( 'branch_borrower_circ_rules', 'maxissueqty' ) ) { >- $dbh->do(" >- INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) >- SELECT categorycode, branchcode, NULL, 'patron_maxissueqty', COALESCE( maxissueqty, '' ) >- FROM branch_borrower_circ_rules >- "); >- $dbh->do(" >- INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) >- SELECT categorycode, branchcode, NULL, 'patron_maxonsiteissueqty', COALESCE( maxonsiteissueqty, '' ) >- FROM branch_borrower_circ_rules >- "); >- $dbh->do("DROP TABLE branch_borrower_circ_rules"); >+ if ( TableExists( 'branch_borrower_circ_rules' ) ) { >+ if ( column_exists( 'branch_borrower_circ_rules', 'maxissueqty' ) ) { >+ $dbh->do(" >+ INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) >+ SELECT categorycode, branchcode, NULL, 'patron_maxissueqty', COALESCE( maxissueqty, '' ) >+ FROM branch_borrower_circ_rules >+ "); >+ $dbh->do(" >+ INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) >+ SELECT categorycode, branchcode, NULL, 'patron_maxonsiteissueqty', COALESCE( maxonsiteissueqty, '' ) >+ FROM branch_borrower_circ_rules >+ "); >+ $dbh->do("DROP TABLE branch_borrower_circ_rules"); >+ } > } > >- if ( column_exists( 'default_borrower_circ_rules', 'maxissueqty' ) ) { >- $dbh->do(" >- INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) >- SELECT categorycode, NULL, NULL, 'patron_maxissueqty', COALESCE( maxissueqty, '' ) >- FROM default_borrower_circ_rules >- "); >- $dbh->do(" >- INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) >- SELECT categorycode, NULL, NULL, 'patron_maxonsiteissueqty', COALESCE( maxonsiteissueqty, '' ) >- FROM default_borrower_circ_rules >- "); >- $dbh->do("DROP TABLE default_borrower_circ_rules"); >+ if ( TableExists( 'default_borrower_circ_rules' ) ) { >+ if ( column_exists( 'default_borrower_circ_rules', 'maxissueqty' ) ) { >+ $dbh->do(" >+ INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) >+ SELECT categorycode, NULL, NULL, 'patron_maxissueqty', COALESCE( maxissueqty, '' ) >+ FROM default_borrower_circ_rules >+ "); >+ $dbh->do(" >+ INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value ) >+ SELECT categorycode, NULL, NULL, 'patron_maxonsiteissueqty', COALESCE( maxonsiteissueqty, '' ) >+ FROM default_borrower_circ_rules >+ "); >+ $dbh->do("DROP TABLE default_borrower_circ_rules"); >+ } > } > > if ( column_exists( 'default_circ_rules', 'maxissueqty' ) ) { >-- >2.21.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18925
:
65238
|
65239
|
65240
|
67024
|
67025
|
67026
|
67621
|
70992
|
70993
|
70994
|
70995
|
70996
|
71032
|
71033
|
71043
|
71044
|
71045
|
71046
|
71047
|
72225
|
72226
|
72227
|
72228
|
72229
|
77225
|
77226
|
77227
|
77228
|
77229
|
78881
|
78882
|
78883
|
78884
|
78885
|
78886
|
79642
|
79643
|
79644
|
79645
|
79646
|
81091
|
81092
|
81093
|
81094
|
81095
|
82927
|
82928
|
82929
|
82930
|
82931
|
85480
|
85481
|
85482
|
85483
|
85484
|
85485
|
85486
|
85939
|
85940
|
85941
|
85942
|
85943
|
85944
|
85945
|
85946
|
85947
|
85948
|
85949
|
85950
|
85951
|
85953
|
85954
|
85955
|
85956
|
85957
|
85958
|
85959
|
85960
|
85961
|
85962
|
85963
|
85964
|
85965
|
86068
|
86069
|
86070
|
86071
|
86072
|
86073
|
86074
|
86075
|
86076
|
86077
|
86078
|
86079
|
86080
|
86081
|
86121
|
86165
|
86206
|
86207