Bugzilla – Attachment 85962 Details for
Bug 18925
Move maxissueqty and maxonsiteissueqty to circulation_rules
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18925: (QA follow-up) Fix basic_workflow.t
Bug-18925-QA-follow-up-Fix-basicworkflowt.patch (text/plain), 2.32 KB, created by
Tomás Cohen Arazi (tcohen)
on 2019-03-02 19:35:08 UTC
(
hide
)
Description:
Bug 18925: (QA follow-up) Fix basic_workflow.t
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2019-03-02 19:35:08 UTC
Size:
2.32 KB
patch
obsolete
>From 175271b2cb00837971fee3f4aada2a9c6e46dfe5 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Sat, 2 Mar 2019 11:03:01 -0300 >Subject: [PATCH] Bug 18925: (QA follow-up) Fix basic_workflow.t > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/selenium/basic_workflow.t | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/selenium/basic_workflow.t b/t/db_dependent/selenium/basic_workflow.t >index 9e9341f103..b7a55d11eb 100644 >--- a/t/db_dependent/selenium/basic_workflow.t >+++ b/t/db_dependent/selenium/basic_workflow.t >@@ -38,6 +38,8 @@ use Time::HiRes qw(gettimeofday); > use C4::Context; > use C4::Biblio qw( AddBiblio ); # We shouldn't use it > >+use Koha::CirculationRules; >+ > use Test::More tests => 20; > use MARC::Record; > use MARC::Field; >@@ -147,7 +149,18 @@ SKIP: { > $dbh->do(q|INSERT INTO itemtypes (itemtype, description, rentalcharge, notforloan) VALUES (?, ?, ?, ?)|, undef, $itemtype->{itemtype}, $itemtype->{description}, $itemtype->{rentalcharge}, $itemtype->{notforloan}); > > my $issuing_rules = $sample_data->{issuingrule}; >- $dbh->do(q|INSERT INTO issuingrules (categorycode, itemtype, branchcode, maxissueqty, issuelength, lengthunit, renewalperiod) VALUES (?, ?, ?, ?, ?, ?, ?)|, undef, $issuing_rules->{categorycode}, $issuing_rules->{itemtype}, $issuing_rules->{branchcode}, $issuing_rules->{maxissueqty}, $issuing_rules->{issuelength}, $issuing_rules->{lengthunit}, $issuing_rules->{renewalperiod}); >+ $dbh->do(q|INSERT INTO issuingrules (categorycode, itemtype, branchcode, issuelength, lengthunit, renewalperiod) VALUES (?, ?, ?, ?, ?, ?)|, undef, $issuing_rules->{categorycode}, $issuing_rules->{itemtype}, $issuing_rules->{branchcode}, $issuing_rules->{issuelength}, $issuing_rules->{lengthunit}, $issuing_rules->{renewalperiod}); >+ Koha::CirculationRules->set_rules( >+ { >+ categorycode => $issuing_rules->{categorycode}, >+ itemtype => $issuing_rules->{itemtype}, >+ branchcode => $issuing_rules->{branchcode}, >+ rules => { >+ maxissueqty => $issuing_rules->{maxissueqty} >+ } >+ } >+ ); >+ > > for my $biblionumber ( @biblionumbers ) { > $driver->get($base_url."/cataloguing/additem.pl?biblionumber=$biblionumber"); >-- >2.21.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18925
:
65238
|
65239
|
65240
|
67024
|
67025
|
67026
|
67621
|
70992
|
70993
|
70994
|
70995
|
70996
|
71032
|
71033
|
71043
|
71044
|
71045
|
71046
|
71047
|
72225
|
72226
|
72227
|
72228
|
72229
|
77225
|
77226
|
77227
|
77228
|
77229
|
78881
|
78882
|
78883
|
78884
|
78885
|
78886
|
79642
|
79643
|
79644
|
79645
|
79646
|
81091
|
81092
|
81093
|
81094
|
81095
|
82927
|
82928
|
82929
|
82930
|
82931
|
85480
|
85481
|
85482
|
85483
|
85484
|
85485
|
85486
|
85939
|
85940
|
85941
|
85942
|
85943
|
85944
|
85945
|
85946
|
85947
|
85948
|
85949
|
85950
|
85951
|
85953
|
85954
|
85955
|
85956
|
85957
|
85958
|
85959
|
85960
|
85961
|
85962
|
85963
|
85964
|
85965
|
86068
|
86069
|
86070
|
86071
|
86072
|
86073
|
86074
|
86075
|
86076
|
86077
|
86078
|
86079
|
86080
|
86081
|
86121
|
86165
|
86206
|
86207