Attachment 86005 Details for Bug 20664 – Bug 20664: (follow-up) Fix test for GetMarcItemFields

[patch] Bug 20664: (follow-up) Fix test for GetMarcItemFields

Bug-20664-follow-up-Fix-test-for-GetMarcItemFields.patch (text/plain), 1.25 KB, created by Josef Moravec on 2019-03-04 15:08:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2019-03-04 15:08:04 UTC

Size: 1.25 KB

patch

obsolete

>From a84191a1ca33f1fd5f4e4edfb74b74ac114ca533 Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Mon, 24 Sep 2018 08:03:25 +0000
>Subject: [PATCH] Bug 20664: (follow-up) Fix test for GetMarcItemFields
>
>Without this patch I got this error running the test:
>
>YAML Error: Stream does not end with newline character
>
>Test plan:
>prove t/db_dependent/Items.t
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/Items.t | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t
>index c11f8f999d..a838d00fba 100755
>--- a/t/db_dependent/Items.t
>+++ b/t/db_dependent/Items.t
>@@ -1108,8 +1108,7 @@ subtest 'tests for GetMarcItemFields' => sub {
>     $item2_marc->field($itemtag)->delete_subfield(code => $item_num_subfield); #because it won't match
> 
>     #Testing with hidden items
>-    my $opachiddenitems = "
>-        withdrawn: [1]";
>+    my $opachiddenitems = "withdrawn: [1]\n";
>     my $hidingrules = YAML::Load($opachiddenitems);
>     my $marc_items = C4::Items::GetMarcItemFields( $biblio->{biblionumber}, [], $hidingrules );
>     @$marc_items[0]->delete_subfield(code => $item_num_subfield);
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20664: 74873 | 75968 | 76045 | 76046 | 76669 | 78868 | 78869 | 78870 | 79225 | 79227 | 79228 | 79229 | 79276 | 79277 | 79278 | 79279 | 84516 | 84517 | 84518 | 84519 | 84520 | 85106 | 85107 | 85108 | 85109 | 85110 | 85776 | 85777 | 85778 | 85779 | 85780 | 85781 | 85898 | 85899 | 85900 | 85901 | 85902 | 85903 | 85904 | 85905 | 86002 | 86003 | 86004 | 86005 | 86006 | 86007 | 86008 | 86009