Attachment 86007 Details for Bug 20664 – Bug 20664: (follow-up) Fix tests on rebase

[patch] Bug 20664: (follow-up) Fix tests on rebase

Bug-20664-follow-up-Fix-tests-on-rebase.patch (text/plain), 2.45 KB, created by Josef Moravec on 2019-03-04 15:08:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2019-03-04 15:08:12 UTC

Size: 2.45 KB

patch

obsolete

>From 3e6d19550d3a4bfb683f2cdb625d0a57a1148561 Mon Sep 17 00:00:00 2001
>From: Ere Maijala <ere.maijala@helsinki.fi>
>Date: Wed, 27 Feb 2019 15:59:23 +0200
>Subject: [PATCH] Bug 20664: (follow-up) Fix tests on rebase
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> t/db_dependent/Items.t | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
>diff --git a/t/db_dependent/Items.t b/t/db_dependent/Items.t
>index a838d00fba..ba8e332820 100755
>--- a/t/db_dependent/Items.t
>+++ b/t/db_dependent/Items.t
>@@ -1021,6 +1021,7 @@ subtest 'tests for GetMarcItem' => sub {
>             restricted       => 1,
>             itemcallnumber   => "",
>             cn_sort          => "",
>+            itype            => 'itemtype'
>         }
>     });
>     my $get_itemnumber = $item1->itemnumber;
>@@ -1067,7 +1068,7 @@ subtest 'tests for GetMarcItemFields' => sub {
>             withdrawn        => 0,
>         }
>     });
>-    push @items, GetItem( $item1->itemnumber );
>+    push @items, Koha::Items->find( $item1->itemnumber )->unblessed;
>     my $item2 = $builder->build_object({
>         class => 'Koha::Items',
>         value => {
>@@ -1082,7 +1083,7 @@ subtest 'tests for GetMarcItemFields' => sub {
>             withdrawn        => 0,
>         }
>     });
>-    push @items, GetItem( $item2->itemnumber );
>+    push @items, Koha::Items->find( $item2->itemnumber )->unblessed;
>     my $item3 = $builder->build_object({
>         class => 'Koha::Items',
>         value => {
>@@ -1097,13 +1098,13 @@ subtest 'tests for GetMarcItemFields' => sub {
>             withdrawn        => 1,
>         }
>     });
>-    push @items, GetItem( $item3->itemnumber );
>+    push @items, Koha::Items->find( $item3->itemnumber )->unblessed;
> 
>     #Get the marc for our items individually for comparison later
>     my $item1_marc = C4::Items::GetMarcItem( $biblio->{biblionumber}, $item1->itemnumber );
>     my $item2_marc = C4::Items::GetMarcItem( $biblio->{biblionumber}, $item2->itemnumber );
>     my $item3_marc = C4::Items::GetMarcItem( $biblio->{biblionumber}, $item3->itemnumber );
>-    my ($itemtag, $item_num_subfield )=C4::Biblio::GetMarcFromKohaField("items.itemnumber"); #get itemnumber tag
>+    my ($itemtag, $item_num_subfield ) = C4::Biblio::GetMarcFromKohaField("items.itemnumber"); #get itemnumber tag
>     $item1_marc->field($itemtag)->delete_subfield(code => $item_num_subfield); #and remove it
>     $item2_marc->field($itemtag)->delete_subfield(code => $item_num_subfield); #because it won't match
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20664: 74873 | 75968 | 76045 | 76046 | 76669 | 78868 | 78869 | 78870 | 79225 | 79227 | 79228 | 79229 | 79276 | 79277 | 79278 | 79279 | 84516 | 84517 | 84518 | 84519 | 84520 | 85106 | 85107 | 85108 | 85109 | 85110 | 85776 | 85777 | 85778 | 85779 | 85780 | 85781 | 85898 | 85899 | 85900 | 85901 | 85902 | 85903 | 85904 | 85905 | 86002 | 86003 | 86004 | 86005 | 86006 | 86007 | 86008 | 86009