Bugzilla – Attachment 8605 Details for
Bug 7702
Test for C4::Heading::MARC21 should only run under MARC21
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7702: MARC21 heading tests should not run under UNIMARC
Bug-7702-MARC21-heading-tests-should-not-run-under.patch (text/plain), 1.63 KB, created by
Magnus Enger
on 2012-03-23 15:15:55 UTC
(
hide
)
Description:
Bug 7702: MARC21 heading tests should not run under UNIMARC
Filename:
MIME Type:
Creator:
Magnus Enger
Created:
2012-03-23 15:15:55 UTC
Size:
1.63 KB
patch
obsolete
>From 78e736051c26a94f58d7bffd39783ce1ed36d2cf Mon Sep 17 00:00:00 2001 >From: Jared Camins-Esakov <jcamins@cpbibliography.com> >Date: Sun, 11 Mar 2012 12:57:11 -0400 >Subject: [PATCH] Bug 7702: MARC21 heading tests should not run under UNIMARC >Content-Type: text/plain; charset="utf-8" > >Skip the MARC21-specific tests in t/Heading_MARC21.t if the marcflavour is >UNIMARC. > >Signed-off-by: Magnus Enger <magnus@enger.priv.no> >I set marcflavour = UNIMARC for testing this. >Before the patch, t/Heading_MARC21.t fails. After the patch it >succeeds. >--- > t/Heading_MARC21.t | 12 ++++++++---- > 1 files changed, 8 insertions(+), 4 deletions(-) > >diff --git a/t/Heading_MARC21.t b/t/Heading_MARC21.t >index 198eaea..0e1f1c9 100755 >--- a/t/Heading_MARC21.t >+++ b/t/Heading_MARC21.t >@@ -7,12 +7,16 @@ use strict; > use warnings; > > use Test::More tests => 3; >+use C4::Context; > > BEGIN { > use_ok('C4::Heading'); > } > >-my $field = MARC::Field->new( '650', ' ', '0', a => 'Uncles', x => 'Fiction' ); >-my $heading = C4::Heading->new_from_bib_field($field); >-is($heading->display_form(), 'Uncles--Fiction', 'Display form generation'); >-is($heading->search_form(), 'Uncles generalsubdiv Fiction', 'Search form generation'); >+SKIP: { >+ skip "MARC21 heading tests not applicable to UNIMARC", 2 if C4::Context->preference('marcflavour') eq 'UNIMARC'; >+ my $field = MARC::Field->new( '650', ' ', '0', a => 'Uncles', x => 'Fiction' ); >+ my $heading = C4::Heading->new_from_bib_field($field); >+ is($heading->display_form(), 'Uncles--Fiction', 'Display form generation'); >+ is($heading->search_form(), 'Uncles generalsubdiv Fiction', 'Search form generation'); >+} >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7702
:
8158
|
8605
|
8606