Bugzilla – Attachment 86064 Details for
Bug 21832
Restore is_expired in ILS-DI GetPatronInfo service
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21832: add unit test
Bug-21832-add-unit-test.patch (text/plain), 1.39 KB, created by
Jonathan Druart
on 2019-03-05 13:10:15 UTC
(
hide
)
Description:
Bug 21832: add unit test
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-03-05 13:10:15 UTC
Size:
1.39 KB
patch
obsolete
>From 96ec89a51d370dc77525ab3442b0350e4032672c Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Tue, 12 Feb 2019 15:52:22 +0100 >Subject: [PATCH] Bug 21832: add unit test > >Adds a check that is_expired exists in service GetPatronInfo. > >Test plan : >Run : prove t/db_dependent/ILSDI_Services.t > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Amended patch: remove ref to bug number, we have git for that >--- > t/db_dependent/ILSDI_Services.t | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/ILSDI_Services.t b/t/db_dependent/ILSDI_Services.t >index 4ec7f81c4b..f3efde85b3 100644 >--- a/t/db_dependent/ILSDI_Services.t >+++ b/t/db_dependent/ILSDI_Services.t >@@ -103,7 +103,7 @@ subtest 'AuthenticatePatron test' => sub { > > subtest 'GetPatronInfo/GetBorrowerAttributes test for extended patron attributes' => sub { > >- plan tests => 4; >+ plan tests => 5; > > $schema->storage->txn_begin; > >@@ -237,6 +237,8 @@ subtest 'GetPatronInfo/GetBorrowerAttributes test for extended patron attributes > # Check results: > is_deeply( $reply->{'attributes'}, [ $cmp ], 'Test GetPatronInfo - show_attributes parameter' ); > >+ ok( exists $reply->{is_expired}, 'There should be the is_expired information'); >+ > # Cleanup > $schema->storage->txn_rollback; > }; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21832
:
82323
|
82363
|
84894
|
84909
|
85022
|
85800
|
85801
|
86063
| 86064 |
86243
|
86701