Attachment 86107 Details for Bug 22303 – Bug 22303: Correct bottom in virtualshelves/addbybiblionumber.tt

[patch] Bug 22303: Correct bottom in virtualshelves/addbybiblionumber.tt

Bug-22303-Correct-bottom-in-virtualshelvesaddbybib.patch (text/plain), 2.01 KB, created by Josef Moravec on 2019-03-05 17:15:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2019-03-05 17:15:15 UTC

Size: 2.01 KB

patch

obsolete

>From 56991879506cfbeaf3a13666e571b657432ce983 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Mon, 11 Feb 2019 09:54:43 +0100
>Subject: [PATCH] Bug 22303: Correct bottom in
> virtualshelves/addbybiblionumber.tt
>
>In virtualshelves/addbybiblionumber.tt the include intranet-bottom.inc which closes the HTML last tag is not the last line of the template.
>
>This patch moved bottom include to last line and uses popup-bottom.inc.
>
>Test plan :
>1) Permission OK :
>1.1) Login in staff interface with user 'Bob'
>1.2) Create a new list 'Readme' : category public and allow changes to contents from anyone
>1.3) Perform a search
>1.4) Check some results
>1.5) Click 'Add to list' and on the list 'Readme'
>1.6) A popup window opens
>1.7) Check its HTML is OK, ending with </html>
>2) Permission KO :
>2.1) Open a new window (Firefox private session) and login in staff interface with user 'Bill'
>2.2) Perform a search
>2.3) Check some results
>2.4) On session of 'Bob', edit list 'Readme'
>2.5) Change : category private and allow changes to contents from owner only
>2.6) On session of 'Bill'
>2.7) Click 'Add to list' and on the list 'Readme'
>2.8) A popup window opens saying 'Sorry, you do not have permission to add items to this list'
>2.9) Check its HTML is OK, ending with </html>
>
>Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> .../intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt  | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt
>index 898a8b3..e43c50e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/addbybiblionumber.tt
>@@ -113,6 +113,7 @@
>         </form>
> 
> 
>+[% END %]
>+
> [% SET popup_window = 1 %]
> [% INCLUDE 'intranet-bottom.inc' %]
>-[% END %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 22303: 84981 | 85882 | 85924 | 86107