Attachment 86170 Details for Bug 18930 – Bug 18930: Do not insert '*' in circulation_rules

[patch] Bug 18930: Do not insert '*' in circulation_rules

Bug-18930-Do-not-insert--in-circulationrules.patch (text/plain), 1.22 KB, created by Tomás Cohen Arazi (tcohen) on 2019-03-06 13:50:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2019-03-06 13:50:19 UTC

Size: 1.22 KB

patch

obsolete

>From d2870a561b1999f8ef27bee3ffdacaff94af483f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 25 Oct 2018 10:16:20 -0300
>Subject: [PATCH] Bug 18930: Do not insert '*' in circulation_rules
>
>We must insert NULL instead, otherwise the FK constraint will fail
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> installer/data/mysql/atomicupdate/bug_18930.perl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_18930.perl b/installer/data/mysql/atomicupdate/bug_18930.perl
>index 3426d994fa..99533dec2d 100644
>--- a/installer/data/mysql/atomicupdate/bug_18930.perl
>+++ b/installer/data/mysql/atomicupdate/bug_18930.perl
>@@ -3,7 +3,7 @@ if( CheckVersion( $DBversion ) ) {
>     if ( column_exists( 'refund_lost_item_fee_rules', 'refund' ) ) {
>         $dbh->do("
>             INSERT INTO circulation_rules ( categorycode, branchcode, itemtype, rule_name, rule_value )
>-            SELECT NULL, branchcode, NULL, 'refund', refund
>+            SELECT NULL, IF(branchcode='*', NULL, branchcode), NULL, 'refund', refund
>             FROM refund_lost_item_fee_rules
>         ");
>         $dbh->do("DROP TABLE refund_lost_item_fee_rules");
>-- 
>2.21.0

Actions: View | Diff | Splinter Review

Attachments on bug 18930: 65243 | 71007 | 81101 | 81148 | 82937 | 82938 | 85492 | 85493 | 86169 | 86170 | 86171 | 89404 | 89405 | 89406 | 90280 | 90281 | 90282 | 90283 | 90284 | 90285 | 90541 | 90542 | 90543 | 90544 | 90545 | 90546 | 90547 | 90548 | 90549 | 91254 | 91255 | 91256 | 91257 | 91258 | 91259 | 91260