Bugzilla – Attachment 86209 Details for
Bug 21953
Term "Lost item" is untranslatable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21953: Term 'Lost item' untranslatable
Bug-21953-Term-Lost-item-untranslatable.patch (text/plain), 2.17 KB, created by
Jonathan Druart
on 2019-03-06 19:09:58 UTC
(
hide
)
Description:
Bug 21953: Term 'Lost item' untranslatable
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2019-03-06 19:09:58 UTC
Size:
2.17 KB
patch
obsolete
>From 834070f84ac878c4d92d645d43f631f0d6943408 Mon Sep 17 00:00:00 2001 >From: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> >Date: Thu, 20 Dec 2018 17:12:21 -0500 >Subject: [PATCH] Bug 21953: Term 'Lost item' untranslatable > >This patch removes the hardcoded untranslatable string >'Lost item' from C4/Circulation.pm. > >To test: >1) Make sure the system preference WhenLostChargeReplacementFee is set to Charge >2) Optional: in Administration > Item types, add a default replacement cost to >the item type you plan to use >3) Loan an item out to a patron >(If there is no default replacement cost, make sure the item has a replacement >price) >4) In the patron's account > Details > Loans, click on the item's barcode >5) Set the lost status to Lost >6) Go back to the patron's account > Fines >7) Notice it is written 'Lost item , Lost item title barcode (title)' >8) If you have another language installed, switch to the other language >and notice the second Lost item is still in English >9) Apply the patch >10) Redo steps 3-6 >11) Notice it is written 'Lost item, title barcode (title)' >12) Optional: switch to another language, notice there is no English string > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index fcf1eab4f6..07b35d08e5 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -3675,7 +3675,7 @@ sub LostItem{ > defined($fix) or warn "_FixOverduesOnReturn($borrowernumber, $itemnumber...) failed!"; # zero is OK, check defined > > if (C4::Context->preference('WhenLostChargeReplacementFee')){ >- C4::Accounts::chargelostitem($borrowernumber, $itemnumber, $issues->{'replacementprice'}, "Lost Item $issues->{'title'} $issues->{'barcode'} $issues->{'itemcallnumber'}"); >+ C4::Accounts::chargelostitem($borrowernumber, $itemnumber, $issues->{'replacementprice'}, "$issues->{'title'} $issues->{'barcode'} $issues->{'itemcallnumber'}"); > #FIXME : Should probably have a way to distinguish this from an item that really was returned. > #warn " $issues->{'borrowernumber'} / $itemnumber "; > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21953
:
82872
|
83433
|
83439
|
86209
|
86210
|
86211
|
86405
|
86406
|
86418
|
87593
|
87594
|
87595
|
87596
|
87597
|
87599
|
87600
|
87601
|
87602
|
87603
|
87659
|
87660
|
87661
|
87662
|
87663
|
87782
|
87783
|
87784
|
87785
|
87786