Bugzilla – Attachment 86215 Details for
Bug 21987
Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 21987: Do not generate true color thumbnails if not needed
Bug-21987-Do-not-generate-true-color-thumbnails-if.patch (text/plain), 1.18 KB, created by
Michal Denar
on 2019-03-06 20:37:49 UTC
(
hide
)
Description:
Bug 21987: Do not generate true color thumbnails if not needed
Filename:
MIME Type:
Creator:
Michal Denar
Created:
2019-03-06 20:37:49 UTC
Size:
1.18 KB
patch
obsolete
>From 212f9387096856dff953c5d1f0d747166e8f261f Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 18 Dec 2018 14:02:19 -0300 >Subject: [PATCH] Bug 21987: Do not generate true color thumbnails if not > needed > >If the original image is not a true color image we should not generate a >true color thumbnail. > >Signed-off-by: Michal Denar <black23@gmail.com> >--- > C4/Images.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Images.pm b/C4/Images.pm >index 37b24179aa..856e894d8a 100644 >--- a/C4/Images.pm >+++ b/C4/Images.pm >@@ -179,8 +179,8 @@ sub _scale_image { > and warn "Reducing image by " > . ( $percent_reduce * 100 ) > . "\% or to $width_reduce pix X $height_reduce pix"; >- my $newimage = GD::Image->new( $width_reduce, $height_reduce, 1 ) >- ; #'1' creates true color image... >+ my $newimage = GD::Image->new( $width_reduce, $height_reduce, $image->trueColor ) >+ ; # if third is set, creates true color image > $newimage->copyResampled( $image, 0, 0, 0, 0, $width_reduce, > $height_reduce, $width, $height ); > return $newimage; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 21987
:
83369
|
83370
|
86215
|
86525
|
86526