Attachment 86220 Details for Bug 22452 – Bug 22452: Fix typos in add mana comment modals

[patch] Bug 22452: Fix typos in add mana comment modals

Bug-22452-Fix-typos-in-add-mana-comment-modals.patch (text/plain), 3.69 KB, created by Josef Moravec on 2019-03-07 07:32:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2019-03-07 07:32:23 UTC

Size: 3.69 KB

patch

obsolete

>From 1c55228e3ff5b869a5c42c69f03f79679eca7979 Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Tue, 26 Feb 2019 12:58:41 +0000
>Subject: [PATCH] Bug 22452: Fix typos in add mana comment modals
>
>There are typos in modal where you can add a comment to mana:
>
>'caracters' should be 'characters'
>'commment' should be 'comment'
>
>Test plan:
>1) Create subscription from Mana
>2) On subscription detail page: report mistake > other a modal is shown
>--> without patch it reads 'Please enter a new commment (max 35 caracters)'
>--> with patch it reads 'Please enter a new comment (max 35 characters)'
>3) The same in mana search resultss and in reports
>---
> .../prog/en/includes/mana/mana-subscription-search-result.inc           | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc            | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc            | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-subscription-search-result.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-subscription-search-result.inc
>index bf7327fdda..c6124aac4e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-subscription-search-result.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/mana/mana-subscription-search-result.inc
>@@ -79,7 +79,7 @@ $(document).ready(function() {
>         <div class="modal-content" style="">
>             <div class="modal-header">
>                 <button type="button" id="commentCloseButton" class="closebtn" aria-hidden="true">Ã</button>
>-                <h3 id="mana_submit_comment"> Please enter a new commment (max 35 caracters)</h3>
>+                <h3 id="mana_submit_comment"> Please enter a new comment (max 35 characters)</h3>
>             </div>
>             <div class="modal-body">
>                 <form>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>index d9aa003d39..e9af1cba1b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>@@ -69,7 +69,7 @@
>                     <div class="modal-content" style="">
>                         <div class="modal-header">
>                             <button type="button" id="mana-comment-close" class="closebtn"  aria-hidden="true">Ã</button>
>-                            <h3 id="mana_submit_comment"> Please enter a new commment (max 35 caracters)</h3>
>+                            <h3 id="mana_submit_comment"> Please enter a new comment (max 35 characters)</h3>
>                         </div>
>                         <div class="modal-body">
>                             <input hidden id="mana-resource" value="report">
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc
>index b217ba6ffc..f018afa586 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc
>@@ -91,7 +91,7 @@
>                     <div class="modal-content" style="">
>                         <div class="modal-header">
>                             <button type="button" id="mana-comment-close" class="closebtn"  aria-hidden="true">Ã</button>
>-                            <h3 id="mana_submit_comment"> Please enter a new commment (max 35 caracters)</h3>
>+                            <h3 id="mana_submit_comment"> Please enter a new comment (max 35 characters)</h3>
>                         </div>
>                         <div class="modal-body">
>                             <input hidden id="mana-resource" value="subscription">
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 22452: 86029 | 86220 | 86242 | 86339