Attachment 86234 Details for Bug 21683 – Bug 21683: (QA follow-up) Drop statistics.proccode

[patch] Bug 21683: (QA follow-up) Drop statistics.proccode

Bug-21683-QA-follow-up-Drop-statisticsproccode.patch (text/plain), 2.65 KB, created by Martin Renvoize (ashimema) on 2019-03-07 08:16:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-03-07 08:16:33 UTC

Size: 2.65 KB

patch

obsolete

>From b5555d05c57701c5de221c6fff89e76fb7dc5cb6 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 7 Mar 2019 08:12:30 +0000
>Subject: [PATCH] Bug 21683: (QA follow-up) Drop statistics.proccode
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../atomicupdate/bug_21683_remove_column_accountno.perl     | 6 +++++-
> installer/data/mysql/kohastructure.sql                      | 2 --
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl b/installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl
>index 02073805ba..4d044c838c 100644
>--- a/installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl
>+++ b/installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl
>@@ -5,7 +5,11 @@ if( CheckVersion( $DBversion ) ) {
>         $dbh->do( "ALTER TABLE accountlines DROP COLUMN accountno" );
>     }
> 
>+    if( column_exists( 'statistics', 'proccode' ) ) {
>+        $dbh->do( "ALTER TABLE statistics DROP COLUMN proccode" );
>+    }
>+
>     # Always end with this (adjust the bug info)
>     SetVersion( $DBversion );
>-    print "Upgrade to $DBversion done (Bug XXXXX - description)\n";
>+    print "Upgrade to $DBversion done (Bug 21683 - Remove accountlines.accountno and statistics.proccode fields)\n";
> }
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index d60bc2895d..5543b03cec 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -1975,7 +1975,6 @@ DROP TABLE IF EXISTS `statistics`;
> CREATE TABLE `statistics` ( -- information related to transactions (circulation and fines) in Koha
>   `datetime` datetime default NULL, -- date and time of the transaction
>   `branch` varchar(10) default NULL, -- foreign key, branch where the transaction occurred
>-  `proccode` varchar(4) default NULL, -- type of procedure used when making payments (does not appear in the code)
>   `value` double(16,4) default NULL, -- monetary value associated with the transaction
>   `type` varchar(16) default NULL, -- transaction type (localuse, issue, return, renew, writeoff, payment)
>   `other` LONGTEXT, -- used by SIP
>@@ -1988,7 +1987,6 @@ CREATE TABLE `statistics` ( -- information related to transactions (circulation
>   `ccode` varchar(80) default NULL, -- foreign key from the items table, links transaction to a specific collection code
>   KEY `timeidx` (`datetime`),
>   KEY `branch_idx` (`branch`),
>-  KEY `proccode_idx` (`proccode`),
>   KEY `type_idx` (`type`),
>   KEY `usercode_idx` (`usercode`),
>   KEY `itemnumber_idx` (`itemnumber`),
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 21683: 81281 | 81282 | 81283 | 82183 | 82184 | 82185 | 82188 | 85531 | 85532 | 85533 | 85534 | 85535 | 85536 | 85537 | 85538 | 86221 | 86222 | 86223 | 86224 | 86225 | 86226 | 86227 | 86228 | 86229 | 86230 | 86231 | 86232 | 86233 | 86234 | 86336 | 86470 | 86471 | 86472 | 86473 | 86474 | 86475