Attachment 86336 Details for Bug 21683 – Bug 21683: (follow-up) Remove last occurences of statistics.proccode

[patch] Bug 21683: (follow-up) Remove last occurences of statistics.proccode

Bug-21683-follow-up-Remove-last-occurences-of-stat.patch (text/plain), 2.08 KB, created by Josef Moravec on 2019-03-08 06:25:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2019-03-08 06:25:32 UTC

Size: 2.08 KB

patch

obsolete

>From 1b371898a67bea6a4772a365322089d41586f205 Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Fri, 8 Mar 2019 06:22:08 +0000
>Subject: [PATCH] Bug 21683: (follow-up) Remove last occurences of
> statistics.proccode
>
>columns.def is used to define descriptions of db columns in guided
>reports
>
>test is not useful anymore IMO
>---
> koha-tmpl/intranet-tmpl/prog/en/columns.def | 1 -
> t/db_dependent/Stats.t                      | 3 +--
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/columns.def b/koha-tmpl/intranet-tmpl/prog/en/columns.def
>index 21c74f2017..70733607ed 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/columns.def
>+++ b/koha-tmpl/intranet-tmpl/prog/en/columns.def
>@@ -108,7 +108,6 @@
> <field name="items.copynumber">Copy number</field>
> <field name="statistics.datetime">Statistics date and time</field>
> <field name="statistics.branch">Library</field>
>-<field name="statistics.proccode">Type of procedure</field>
> <field name="statistics.value">Value</field>
> <field name="statistics.type">Type</field>
> <field name="statistics.other"></field>
>diff --git a/t/db_dependent/Stats.t b/t/db_dependent/Stats.t
>index 2c6cdbcf76..7e2e6f7b6c 100644
>--- a/t/db_dependent/Stats.t
>+++ b/t/db_dependent/Stats.t
>@@ -4,7 +4,7 @@ use Modern::Perl;
> use C4::Stats;
> use Koha::Database;
> 
>-use Test::More tests => 19;
>+use Test::More tests => 18;
> 
> BEGIN {
>     use_ok('C4::Stats');
>@@ -119,7 +119,6 @@ is ($params->{other},          $line->{other},          "UpdateStats save other
> is ($params->{itemtype},       $line->{itemtype},       "UpdateStats save itemtype param in itemtype field of statistics table");
> is ($params->{location},       $line->{location},       "UpdateStats save location param in location field of statistics table");
> is ($params->{ccode},          $line->{ccode},          "UpdateStats save ccode param in ccode field of statistics table");
>-is (undef,                     $line->{proccode},       "UpdateStats save no proccode param in proccode field of statistics table");
> 
> $dbh->do(q|DELETE FROM statistics|);
> $params = {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21683: 81281 | 81282 | 81283 | 82183 | 82184 | 82185 | 82188 | 85531 | 85532 | 85533 | 85534 | 85535 | 85536 | 85537 | 85538 | 86221 | 86222 | 86223 | 86224 | 86225 | 86226 | 86227 | 86228 | 86229 | 86230 | 86231 | 86232 | 86233 | 86234 | 86336 | 86470 | 86471 | 86472 | 86473 | 86474 | 86475