Bugzilla – Attachment 86399 Details for
Bug 22477
Missing DataTables configuration when searching patrons for holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 22477: Missing DataTables configuration when searching patrons for holds
Bug-22477-Missing-DataTables-configuration-when-se.patch (text/plain), 2.01 KB, created by
Bin Wen
on 2019-03-08 19:23:38 UTC
(
hide
)
Description:
Bug 22477: Missing DataTables configuration when searching patrons for holds
Filename:
MIME Type:
Creator:
Bin Wen
Created:
2019-03-08 19:23:38 UTC
Size:
2.01 KB
patch
obsolete
>From 9406fb081d96978ea0d84349ee65a52bd86fb86e Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 7 Mar 2019 17:28:34 +0000 >Subject: [PATCH] Bug 22477: Missing DataTables configuration when searching > patrons for holds > >This patch adds columns configuration to the holds request page to fix a >JavaScript error in the console and to allow the patron search results >table to be enabled as a DataTable. > >To reproduce: Place a hold on a title in the staff client. When prompted >for a patron, perform a search which will return multiple results. The >patron search results will appear in an unsortable table. A JS error can >be seen in the browser console. > >To test, apply the patch and repeat the steps above. The patron search >results table should be sortable and there should be no JS error. > >Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> >Signed-off-by: Bin Wen <bin.wen@inlibro.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 8a0cc00eba..c0c7a07508 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -658,6 +658,7 @@ > [% MACRO jsinclude BLOCK %] > [% INCLUDE 'datatables.inc' %] > [% INCLUDE 'calendar.inc' %] >+ [% INCLUDE 'columns_settings.inc' %] > [% Asset.js("js/circ-patron-search-results.js") | $raw %] > <script> > var MSG_CONFIRM_DELETE_HOLD = _("Are you sure you want to cancel this hold?"); >@@ -670,6 +671,7 @@ > [% END %][% END %][% END %] > }; > var MSG_NO_ITEMS_AVAILABLE = _("A hold cannot be requested on any of these items."); >+ columns_settings_borrowers_table = [% ColumnsSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %] > > $(document).ready(function() { > function ToggleHoldsToPlace() { >-- >2.17.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 22477
:
86328
|
86398
|
86399
|
86467