Attachment 86460 Details for Bug 15400 – Bug 15400: (follow-up) Restore 'years' string, remove untranslatable string

[patch] Bug 15400: (follow-up) Restore 'years' string, remove untranslatable string

Bug-15400-follow-up-Restore-years-string-remove-un.patch (text/plain), 3.30 KB, created by Josef Moravec on 2019-03-11 14:30:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2019-03-11 14:30:50 UTC

Size: 3.30 KB

patch

obsolete

>From bfd31e6004078f3fcb536e814a8ced4f5eee231e Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Mon, 11 Mar 2019 14:25:46 +0000
>Subject: [PATCH] Bug 15400: (follow-up) Restore 'years' string, remove
> untranslatable string
>
>---
> circ/ysearch.pl                                          | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc | 7 ++++++-
> koha-tmpl/intranet-tmpl/prog/en/includes/patron-age.inc  | 7 ++++---
> 3 files changed, 11 insertions(+), 5 deletions(-)
>
>diff --git a/circ/ysearch.pl b/circ/ysearch.pl
>index 71b48ca4f3..3e31f7f852 100755
>--- a/circ/ysearch.pl
>+++ b/circ/ysearch.pl
>@@ -85,7 +85,7 @@ while ( my $b = $borrowers_rs->next ) {
>         firstname      => $b->firstname  // '',
>         cardnumber     => $b->cardnumber // '',
>         dateofbirth    => format_sqldatetime($b->dateofbirth, undef, undef, 1) // '',
>-        age            => $b->get_age    // 'Age unknown',
>+        age            => $b->get_age    // '',
>         address        => $b->address    // '',
>         city           => $b->city       // '',
>         zipcode        => $b->zipcode    // '',
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc
>index bee29cf62d..708feafeae 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc
>@@ -103,9 +103,14 @@
>                 }).data( "ui-autocomplete" );
>                 if( obj ) {
>                     obj._renderItem = function( ul, item ) {
>+                        var itemString = "<a>" + item.surname + ", " + item.firstname + " (" + item.cardnumber + ") <small>";
>+                        if( item.dateofbirth ) {
>+                            itemString += item.dateofbirth + " (" + item.age + " " +  _("years") + "), ";
>+                        }
>+                        itemString += item.address + " " + item.city + " " + item.zipcode + " " + item.country + "</small></a>";
>                         return $( "<li></li>" )
>                         .data( "ui-autocomplete-item", item )
>-                        .append( "<a>" + item.surname + ", " + item.firstname + " (" + item.cardnumber + ") <small>" + item.dateofbirth + " (" + item.age + ") " + item.address + " " + item.city + " " + item.zipcode + " " + item.country + "</small></a>" )
>+                        .append( itemString )
>                         .appendTo( ul );
>                     };
>                 }
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-age.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-age.inc
>index 899ce163c3..4dc3c333f2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-age.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-age.inc
>@@ -1,8 +1,9 @@
> [%- USE KohaDates -%]
>+[%- USE I18N -%]
> [%- IF ( patron ) -%]
>     [%- IF ( patron.dateofbirth ) -%]
>-        [% patron.dateofbirth | $KohaDates -%]
>-        [%- IF ( patron.get_age ) %] ([% patron.get_age | html %])
>-        [%- ELSIF ( patron.age ) %] ([% patron.age | html %])[% END -%]
>+        [%- patron.dateofbirth | $KohaDates %]
>+        [%- SET age = (patron.get_age != undef) ? patron.get_age : patron.age -%]
>+        [% I18N.tnx('({age} year)', '({age} years)', age, { age => age }) | html %]
>    [%- END -%]
> [%- END -%]
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 15400: 45882 | 46935 | 81892 | 82714 | 85432 | 85479 | 85494 | 85495 | 85496 | 85497 | 86457 | 86458 | 86459 | 86460 | 88274 | 88275 | 88276 | 88277 | 88278 | 88845 | 88846 | 88977 | 88978 | 88979 | 88980 | 88981 | 100047 | 100048 | 100049 | 100050 | 100051 | 100065 | 100066 | 100067 | 100068 | 100069 | 100118 | 103373 | 106133 | 106134 | 106135 | 106136 | 106137 | 106138 | 106139 | 106140 | 106307