Attachment 86528 Details for Bug 19417 – Bug 19417: Display full error text when problem importing records

[patch] Bug 19417: Display full error text when problem importing records

Bug-19417-Display-full-error-text-when-problem-imp.patch (text/plain), 3.05 KB, created by Martin Renvoize (ashimema) on 2019-03-12 13:15:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2019-03-12 13:15:28 UTC

Size: 3.05 KB

patch

obsolete

>From 47c5c265662cc1b6cd9e41b648abb33598a8ff92 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 5 Oct 2017 15:26:46 +0000
>Subject: [PATCH] Bug 19417: Display full error text when problem importing
> records
>
>To test:
>1 - Upload a file to stage
>2 - Select your import options
>3 - Delete the file from the server, example:
>    sudo rm /tmp/koha_kohadev_uploads/
>4 - 'Click stage for import'
>5 - Get an alert 'Failed to submit form: error'
>6 - Apply patches
>7 - Repeat 1-4
>8 - Get a pretty error with additional info
>
>Signed-off-by: Liz Rea <wizzyrea@gmail.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/lib/jquery/plugins/humanmsg.js         | 1 -
> .../intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt   | 3 +++
> koha-tmpl/intranet-tmpl/prog/js/background-job-progressbar.js  | 2 +-
> 3 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/lib/jquery/plugins/humanmsg.js b/koha-tmpl/intranet-tmpl/lib/jquery/plugins/humanmsg.js
>index 347d345230..a4c1ab9928 100644
>--- a/koha-tmpl/intranet-tmpl/lib/jquery/plugins/humanmsg.js
>+++ b/koha-tmpl/intranet-tmpl/lib/jquery/plugins/humanmsg.js
>@@ -75,7 +75,6 @@ var humanMsg = {
> 	bindEvents: function() {
> 	// Remove message if mouse is moved or key is pressed
> 		jQuery(document)
>-			.mousemove(humanMsg.removeMsg)
> 			.click(humanMsg.removeMsg)
> 			.keypress(humanMsg.removeMsg)
> 	},
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt
>index e169bcd12d..751570ec07 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt
>@@ -8,6 +8,8 @@
>     #fileuploadstatus,#fileuploadfailed,#fileuploadcancel,#jobpanel,#jobstatus,#jobfailed { display : none; }
> </style>
> 
>+[% Asset.css("css/humanmsg.css") %]
>+
> </head>
> <body id="tools_stage-marc-import" class="tools">
> [% INCLUDE 'header.inc' %]
>@@ -213,6 +215,7 @@
>     [% Asset.js("js/tools-menu.js") | $raw %]
>     [% Asset.js("js/background-job-progressbar.js") | $raw %]
>     [% Asset.js("js/file-upload.js") | $raw %]
>+    [% Asset.js("lib/jquery/plugins/humanmsg.js") | $raw %]
>     <script>
>         var xhr;
>         $(document).ready(function(){
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/background-job-progressbar.js b/koha-tmpl/intranet-tmpl/prog/js/background-job-progressbar.js
>index cc08618d11..66dac87283 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/background-job-progressbar.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/background-job-progressbar.js
>@@ -69,7 +69,7 @@ function submitBackgroundJob(f) {
>                 backgroundJobProgressTimer = setInterval("updateJobProgress()", 500);
>             },
>             error: function(xml, textStatus) {
>-                alert('Failed to submit form: ' + textStatus);
>+                humanMsg.displayMsg( '<p>' + _('Failed to submit form: ') + textStatus + '</p></br>'+xml.responseText, { className: 'humanError' } );
>             }
> 
>         });
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 19417: 67648 | 85353 | 85367 | 86033 | 86037 | 86038 | 86039 | 86042 | 86528 | 86529 | 86530