Attachment 8653 Details for Bug 7485 – Bug 7485 - Cannot edit barcode on Fast Add

[patch] Bug 7485 - Cannot edit barcode on Fast Add

Bug-7485---Cannot-edit-barcode-on-Fast-Add.patch (text/plain), 1.58 KB, created by Liz Rea on 2012-03-27 18:04:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Liz Rea

Created: 2012-03-27 18:04:25 UTC

Size: 1.58 KB

patch

obsolete

>From b66248b1dd630d386b1ae60e00c642f7bcf2e55c Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 27 Mar 2012 12:01:33 -0400
>Subject: [PATCH] Bug 7485 - Cannot edit barcode on Fast Add
>Content-Type: text/plain; charset="utf-8"
>
>Simple fix, a special case was added for the fast add framework
>in the case that an item was being checked out that had not been
>catalogued. In that case, the barcode was being passed as a parameter
>through addbiblio.pl to additem.pl.
>
>This barcode param was used to overwrite the existing value, so if
>no barcode param was passed ( which is only the case with fast adds
>from the circ screen ), the barcode field would appear empty in the
>items editor.
>
>This commit causes that special case code to check for an existing
>barcode value first, and only use the cgi parameter 'branch' in the
>case that there is no existing barcode value.
>
>Signed-off-by: Liz Rea <wizzyrea@gmail.com>
>Editing barcode of fast added item now works. Passes t xt
>
>Recommend this for 3.6 release.
>---
> cataloguing/additem.pl |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl
>index 91dc9e7..9c8120e 100755
>--- a/cataloguing/additem.pl
>+++ b/cataloguing/additem.pl
>@@ -147,7 +147,7 @@ sub generate_subfield_form {
>             }
>         }
>         
>-        if ($frameworkcode eq 'FA' && $subfieldlib->{kohafield} eq 'items.barcode'){
>+        if ($frameworkcode eq 'FA' && $subfieldlib->{kohafield} eq 'items.barcode' && !$value){
> 	    my $input = new CGI;
> 	    $value = $input->param('barcode');
> 	}
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 7485: 8649 | 8650 | 8653