Bugzilla – Attachment 86569 Details for
Bug 14457
Integrate LIBRIS spellchecking
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14457 - QA follow up
Bug-14457---QA-follow-up.patch (text/plain), 4.76 KB, created by
Björn Nylén
on 2019-03-13 11:38:42 UTC
(
hide
)
Description:
Bug 14457 - QA follow up
Filename:
MIME Type:
Creator:
Björn Nylén
Created:
2019-03-13 11:38:42 UTC
Size:
4.76 KB
patch
obsolete
>From 53a95df066d02d1bef605cc56c62f56bb3a7fff0 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Bj=C3=B6rn=20Nyl=C3=A9n?= <bjorn.nylen@ub.lu.se> >Date: Wed, 13 Mar 2019 12:28:55 +0100 >Subject: [PATCH] Bug 14457 - QA follow up > >Pod coverage for 'NAME'. >Moved sysprefs in order and moved semicolon to last line. >Replaced tab indentation with spaces. >Added "Swedish service for spellchecking" to the syspref description. >--- > Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm | 8 ++++++++ > installer/data/mysql/sysprefs.sql | 7 ++++--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt | 4 ++-- > .../prog/en/modules/admin/preferences/searching.pref | 1 + > 4 files changed, 15 insertions(+), 5 deletions(-) > >diff --git a/Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm b/Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm >index 6177892..e0a8b1b 100644 >--- a/Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm >+++ b/Koha/SuggestionEngine/Plugin/LibrisSpellcheck.pm >@@ -71,10 +71,18 @@ This module provides facilities for using the LIBRIS spell checker API > > =over > >+=item NAME >+ >+my $name = $plugin->NAME; >+ >+=back >+ > =item get_suggestions(query) > > Sends in the search query and gets an XML with a suggestion > >+my $suggestions = $plugin->get_suggestions(\%query); >+ > =back > > =cut >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 3c5d6fe..5e5d890 100644 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -267,6 +267,8 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('LibraryThingForLibrariesEnabled','0','','Enable or Disable Library Thing for Libraries Features','YesNo'), > ('LibraryThingForLibrariesID','','','See:http://librarything.com/forlibraries/','free'), > ('LibraryThingForLibrariesTabbedView','0','','Put LibraryThingForLibraries Content in Tabs.','YesNo'), >+('LibrisKey', '', 'This key must be obtained at http://api.libris.kb.se/. It is unique for the IP of the server.', NULL, 'Free'), >+('LibrisURL', 'http://api.libris.kb.se/bibspell/', 'This it the base URL for the Libris spellchecking API.',NULL,'Free'), > ('LinkerKeepStale','0',NULL,'If ON the authority linker will keep existing authority links for headings where it is unable to find a match.','YesNo'), > ('LinkerModule','Default','Default|FirstMatch|LastMatch','Chooses which linker module to use (see documentation).','Choice'), > ('LinkerOptions','','','A pipe-separated list of options for the linker.','free'), >@@ -643,6 +645,5 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, ` > ('XSLTListsDisplay','default','','Enable XSLT stylesheet control over lists pages display on intranet','Free'), > ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over results page display on intranet','Free'), > ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'), >-('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo'), >-('LibrisKey', '', 'This key must be obtained at http://api.libris.kb.se/. It is unique for the IP of the server.', NULL, 'Free'), >-('LibrisURL', 'http://api.libris.kb.se/bibspell/', 'This it the base URL for the Libris spellchecking API.',NULL,'Free'); >+('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo') >+; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt >index 32855eb..5bd7448 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/didyoumean.tt >@@ -16,8 +16,8 @@ > Suggest that patrons expand their searches to include > broader/narrower/related terms. > [% CASE 'LibrisSpellcheck' %] >- Use the LIBRIS spellcheck API. >- [% END %] >+ Use the LIBRIS spellcheck API. >+ [% END %] > </div> > </div> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref >index fd53954..f1b87d8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref >@@ -245,6 +245,7 @@ Searching: > - on all variations of the ISBN. Note that this preference has no effect if UseQueryParser is on. > Did you Mean/Spell checking: > - >+ - "Swedish service for spellchecking.<br/>" > - LIBRIS Spellchecking API key > - pref: LibrisKey > - "Can be obtained at http://api.libris.kb.se/bibspell." >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14457
:
40816
|
40827
|
45967
|
55948
|
56609
|
86569
|
87374
|
87375
|
87376
|
87377