Bugzilla – Attachment 86615 Details for
Bug 14591
book drop / drop box mode incorrectly decrements accrued overdue fines
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14591: Update other calls to AddReturn
Bug-14591-Update-other-calls-to-AddReturn.patch (text/plain), 1.98 KB, created by
Kyle M Hall (khall)
on 2019-03-14 15:39:33 UTC
(
hide
)
Description:
Bug 14591: Update other calls to AddReturn
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2019-03-14 15:39:33 UTC
Size:
1.98 KB
patch
obsolete
>From 8330d44e96f51e3afbe9371d077f5e0b2dd1a2fb Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 14 Mar 2019 07:58:09 -0400 >Subject: [PATCH] Bug 14591: Update other calls to AddReturn > >--- > C4/Circulation.pm | 8 +------- > C4/SIP/ILS/Transaction/Checkin.pm | 2 +- > 2 files changed, 2 insertions(+), 8 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 587cf0868a..76e6c74058 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -1759,7 +1759,7 @@ sub GetBranchItemRule { > =head2 AddReturn > > ($doreturn, $messages, $iteminformation, $borrower) = >- &AddReturn( $barcode, $branch [,$exemptfine] [,$dropbox] [,$returndate] ); >+ &AddReturn( $barcode, $branch [,$exemptfine] [,$returndate] ); > > Returns a book. > >@@ -1772,12 +1772,6 @@ Returns a book. > =item C<$exemptfine> indicates that overdue charges for the item will be > removed. Optional. > >-=item C<$dropbox> indicates that the check-in date is assumed to be >-yesterday, or the last non-holiday as defined in C4::Calendar . If >-overdue charges are applied and C<$dropbox> is true, the last charge >-will be removed. This assumes that the fines accrual script has run >-for _today_. Optional. >- > =item C<$return_date> allows the default return date to be overridden > by the given return date. Optional. > >diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm >index a35009f511..ca34ccb128 100644 >--- a/C4/SIP/ILS/Transaction/Checkin.pm >+++ b/C4/SIP/ILS/Transaction/Checkin.pm >@@ -65,7 +65,7 @@ sub do_checkin { > . substr( $return_date, 16, 2 ); > > $debug and warn "do_checkin() calling AddReturn($barcode, $branch)"; >- my ($return, $messages, $issue, $borrower) = AddReturn($barcode, $branch, undef, undef, $return_date); >+ my ($return, $messages, $issue, $borrower) = AddReturn($barcode, $branch, undef, $return_date); > $self->alert(!$return); > # ignoring messages: NotIssued, WasLost, WasTransfered > >-- >2.17.2 (Apple Git-113)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14591
:
86611
|
86612
|
86613
|
86614
|
86615
|
86616
|
86618
|
86619
|
86620
|
86621
|
86639
|
86640
|
86641
|
86642
|
86643
|
86676