Bugzilla – Attachment 86676 Details for
Bug 14591
book drop / drop box mode incorrectly decrements accrued overdue fines
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14591: (QA follow-up) Fix call to AddReturn for SIP
Bug-14591-QA-follow-up-Fix-call-to-AddReturn-for-S.patch (text/plain), 1.35 KB, created by
Kyle M Hall (khall)
on 2019-03-15 14:32:28 UTC
(
hide
)
Description:
Bug 14591: (QA follow-up) Fix call to AddReturn for SIP
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2019-03-15 14:32:28 UTC
Size:
1.35 KB
patch
obsolete
>From a5d63952a5602581a0244a3fa6fe91117b73d8ea Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 15 Mar 2019 10:32:14 -0400 >Subject: [PATCH] Bug 14591: (QA follow-up) Fix call to AddReturn for SIP > >--- > C4/SIP/ILS/Transaction/Checkin.pm | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > >diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm >index c8b8fe8b41..0303a47e97 100644 >--- a/C4/SIP/ILS/Transaction/Checkin.pm >+++ b/C4/SIP/ILS/Transaction/Checkin.pm >@@ -12,9 +12,10 @@ use strict; > use C4::SIP::ILS::Transaction; > > use C4::Circulation; >-use C4::Reserves qw( ModReserveAffect ); >-use C4::Items qw( ModItemTransfer ); > use C4::Debug; >+use C4::Items qw( ModItemTransfer ); >+use C4::Reserves qw( ModReserveAffect ); >+use Koha::DateUtils qw( dt_from_string ); > > use parent qw(C4::SIP::ILS::Transaction); > >@@ -67,7 +68,7 @@ sub do_checkin { > . substr( $return_date, 16, 2 ); > > $debug and warn "do_checkin() calling AddReturn($barcode, $branch)"; >- my ($return, $messages, $issue, $borrower) = AddReturn($barcode, $branch, undef, $return_date); >+ my ($return, $messages, $issue, $borrower) = AddReturn($barcode, $branch, undef, dt_from_string($return_date)); > $self->alert(!$return); > # ignoring messages: NotIssued, WasLost, WasTransfered > >-- >2.17.2 (Apple Git-113)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14591
:
86611
|
86612
|
86613
|
86614
|
86615
|
86616
|
86618
|
86619
|
86620
|
86621
|
86639
|
86640
|
86641
|
86642
|
86643
| 86676