Attachment 86693 Details for Bug 20728 – Bug 20728: Proof that there is no cheating

[patch] Bug 20728: Proof that there is no cheating

Bug-20728-Proof-that-there-is-no-cheating.patch (text/plain), 2.05 KB, created by Jonathan Druart on 2019-03-15 22:41:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2019-03-15 22:41:39 UTC

Size: 2.05 KB

patch

obsolete

>From b9cdb450efe6f9d207dff98239da7e3c32018dfb Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 15 Mar 2019 19:24:19 -0300
>Subject: [PATCH] Bug 20728: Proof that there is no cheating
>
>---
> C4/Acquisition.pm | 35 +++++++++++------------------------
> 1 file changed, 11 insertions(+), 24 deletions(-)
>
>diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm
>index 1ad7a2361c..1cd4485609 100644
>--- a/C4/Acquisition.pm
>+++ b/C4/Acquisition.pm
>@@ -1280,30 +1280,17 @@ Returns a reference-to-hash describing the last order received for a subscriptio
> 
> sub GetLastOrderReceivedFromSubscriptionid {
>     my ( $subscriptionid ) = @_;
>-    my $dbh                = C4::Context->dbh;
>-    my $query              = qq|
>-        SELECT * FROM aqorders
>-        LEFT JOIN subscription
>-            ON ( aqorders.subscriptionid = subscription.subscriptionid )
>-        WHERE aqorders.subscriptionid = ?
>-            AND aqorders.datereceived =
>-                (
>-                    SELECT MAX( aqorders.datereceived )
>-                    FROM aqorders
>-                    LEFT JOIN subscription
>-                        ON ( aqorders.subscriptionid = subscription.subscriptionid )
>-                        WHERE aqorders.subscriptionid = ?
>-                            AND aqorders.datereceived IS NOT NULL
>-                )
>-        ORDER BY ordernumber DESC
>-        LIMIT 1
>-    |;
>-    my $result_set =
>-      $dbh->selectall_arrayref( $query, { Slice => {} }, $subscriptionid, $subscriptionid );
>-
>-    # result_set assumed to contain 1 match
>-    return $result_set->[0];
>-
>+    my $lastOrderReceived = Koha::Acquisition::Orders->search(
>+        {
>+            subscriptionid => $subscriptionid,
>+            datereceived   => { '!=' => undef }
>+        },
>+        {
>+            order_by =>
>+              [ { -desc => 'datereceived' }, { -desc => 'ordernumber' } ]
>+        }
>+    );
>+    return $lastOrderReceived->count ? $lastOrderReceived->next->unblessed : undef;
> }
> 
> #------------------------------------------------------------#
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 20728: 86693 | 86694 | 86695 | 99655 | 99656 | 99657 | 99877 | 99878 | 99879 | 102873 | 102874 | 102875