Bugzilla – Attachment 86877 Details for
Bug 17385
Add custom export formats for bibliographic records
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder
Bug-17385-QA-follow-up-Do-not-needlessly-scan-bibl.patch (text/plain), 1.92 KB, created by
Marcel de Rooy
on 2019-03-22 09:02:51 UTC
(
hide
)
Description:
Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2019-03-22 09:02:51 UTC
Size:
1.92 KB
patch
obsolete
>From 1c5d580865098115b906be30b1e1dd0a8a269407 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 22 Mar 2019 08:03:16 +0000 >Subject: [PATCH] Bug 17385: (QA follow-up) Do not needlessly scan biblioexport > folder >Content-Type: text/plain; charset=utf-8 > >Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. > >Test plan: >Run t/db_dependent/XSLT.t > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/XSLT.pm | 2 ++ > t/db_dependent/XSLT.t | 23 +++++++++++++++++++++++ > 2 files changed, 25 insertions(+) > create mode 100644 t/db_dependent/XSLT.t > >diff --git a/C4/XSLT.pm b/C4/XSLT.pm >index d17a3b9894..73b18933b6 100644 >--- a/C4/XSLT.pm >+++ b/C4/XSLT.pm >@@ -377,6 +377,8 @@ sub engine { > > sub CustomXSLTExportList { > my $opac = shift; # opac (1) vs intranet (0) >+ return [] if C4::Context->preference('OpacExportOptions') !~ /custom/; >+ > my @tabFiles; > > my $dir = C4::Context->config( $opac ? 'opachtdocs' : 'intrahtdocs') . >diff --git a/t/db_dependent/XSLT.t b/t/db_dependent/XSLT.t >new file mode 100644 >index 0000000000..5f91cdb44b >--- /dev/null >+++ b/t/db_dependent/XSLT.t >@@ -0,0 +1,23 @@ >+use Modern::Perl; >+use Test::More tests => 1; >+ >+use t::lib::Mocks; >+use C4::XSLT; >+use Koha::Database; >+ >+our $schema = Koha::Database->new->schema; >+ >+# Here we go >+$schema->storage->txn_begin; >+subtest 'CustomXSLTExportList: Check export options' => sub { >+ plan tests => 2; >+ t::lib::Mocks::mock_preference('OpacExportOptions', 'custom'); >+ >+ my $list = C4::XSLT::CustomXSLTExportList(1); >+ is( @$list>0, 1, 'We expect at least one result: simple export' ); >+ >+ t::lib::Mocks::mock_preference('OpacExportOptions', 'dc'); >+ $list = C4::XSLT::CustomXSLTExportList(1); >+ is( @$list, 0, 'We expect an empty list now' ); >+}; >+$schema->storage->txn_rollback; >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17385
:
55961
|
58308
|
64033
|
64034
|
67357
|
67579
|
74660
|
74661
|
79055
|
79056
|
80675
|
81385
|
81386
|
84388
|
84389
|
84390
|
86875
|
86876
|
86877
|
86878
|
86879
|
86880
|
97076
|
97101
|
97102
|
97103
|
97104
|
97105
|
100289
|
100290
|
100291
|
100292
|
100293
|
100663
|
100670
|
100671
|
100672
|
100673
|
100674
|
100675
|
112671
|
112672
|
112673
|
112674
|
112675
|
112676
|
112677
|
112678
|
112679
|
112680
|
112681
|
112682
|
112956
|
112957
|
112958
|
112959
|
130283
|
130284
|
130285
|
130286
|
130287
|
130691
|
130692
|
130693
|
130694
|
130695
|
131492
|
132488
|
132489
|
132490
|
132491
|
132492
|
132493
|
132581
|
133498
|
133499
|
133500
|
133501
|
133502
|
133503
|
133504
|
138031
|
138032
|
138033
|
138034
|
138035
|
138036
|
138037
|
138082
|
138083
|
138084
|
138085
|
138086
|
138087
|
138088
|
138132
|
139277
|
139278
|
139279
|
139280
|
139281
|
139282
|
139283
|
139284
|
141157
|
141158
|
141159
|
141160
|
141161
|
141162
|
141163
|
141164
|
144335
|
144336
|
144380
|
144384
|
151095
|
151096
|
151097
|
151098
|
151099
|
151102
|
151103
|
151104
|
151105
|
151106
|
151377
|
151378
|
151379
|
151380
|
151381
|
154379
|
154380
|
154381
|
154382
|
154383
|
156815
|
156816
|
156817
|
156818
|
156819
|
159142
|
159143
|
159144
|
159145
|
159146
|
159147
|
159148
|
163623
|
170014
|
170015
|
170016
|
170017
|
170018
|
170019
|
170026
|
170027
|
170028
|
170029
|
170030
|
170031
|
170983
|
170984
|
170985
|
170986
|
170987
|
170988