Attachment 86884 Details for Bug 12159 – Bug 12159: (QA follow-up) Rename relation in Patron::Attributes

[patch] Bug 12159: (QA follow-up) Rename relation in Patron::Attributes

Bug-12159-QA-follow-up-Rename-relation-in-PatronAt.patch (text/plain), 1.07 KB, created by Marcel de Rooy on 2019-03-22 11:06:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2019-03-22 11:06:42 UTC

Size: 1.07 KB

patch

obsolete

>From 33dc6610cdbcfdbe1786b7c00745a84e71cde552 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 22 Mar 2019 10:49:03 +0000
>Subject: [PATCH] Bug 12159: (QA follow-up) Rename relation in
> Patron::Attributes
>Content-Type: text/plain; charset=utf-8
>
>It seems that we do not need the extra belongs_to in the schema result
>files if we rename the relation to code.
>
>Test plan:
>Run t/db_dependent/Koha/Patrons.t
>Run t/db_dependent/Koha/Patron/Attributes.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> Koha/Patron/Attributes.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Patron/Attributes.pm b/Koha/Patron/Attributes.pm
>index 1bbd35b5a1..514b1d3288 100644
>--- a/Koha/Patron/Attributes.pm
>+++ b/Koha/Patron/Attributes.pm
>@@ -56,7 +56,7 @@ sub search {
>         $branchcode
>         ? {
>             join => {
>-                'borrower_attribute_types' => 'borrower_attribute_types_branches'
>+                'code' => 'borrower_attribute_types_branches'
>             },
>         } : {};
>     $attributes //= {};
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 12159: 72902 | 73018 | 73019 | 74781 | 74782 | 74791 | 74792 | 75811 | 75812 | 75822 | 76945 | 76946 | 76947 | 77050 | 77051 | 77052 | 86166 | 86167 | 86168 | 86882 | 86883 | 86884 | 86885